You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/02/03 22:26:23 UTC
[kudu-CR] [java] Document increasing Intellij intellisense configuration
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15155
Change subject: [java] Document increasing Intellij intellisense configuration
......................................................................
[java] Document increasing Intellij intellisense configuration
Our Protobuf files generate Java classes that are too large for
Intellij to provide code assistance for by default.
This results in what appears to be missing classes and difficulty
working with the Protobuf classes.
I added a note under the Intellij section of the Java readme to help
others workaround this.
Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
---
M java/README.adoc
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/15155/1
--
To view, visit http://gerrit.cloudera.org:8080/15155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Gerrit-Change-Number: 15155
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Document increasing Intellij intellisense configuration
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15155 )
Change subject: [java] Document increasing Intellij intellisense configuration
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15155/1/java/README.adoc
File java/README.adoc:
http://gerrit.cloudera.org:8080/#/c/15155/1/java/README.adoc@143
PS1, Line 143: Some of the classes generated by Kudu Protobuf files are larger than the
: default "intellisense" limit in Intellij. This means Intellij won't
: provide code assistance for the classes in those files and may indicate
: that the classes in those files are not found. Follow the instructions
: https://intellij-support.jetbrains.com/hc/en-us/articles/206544869-Configuring-JVM-options-and-platform-properties[here]
: to set "idea.max.intellisense.filesize=5000" in the `idea.properties` file
: to work around this issue.
> As an alternative approach, does it make sense to remove the protobuf auto-
I don't think so, it affects the usability of those classes.
The alternative is to break up the protobuf classes, but I don't think it's worth it in this case given the config change is easy.
--
To view, visit http://gerrit.cloudera.org:8080/15155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Gerrit-Change-Number: 15155
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Feb 2020 03:24:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Document increasing Intellij intellisense configuration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15155 )
Change subject: [java] Document increasing Intellij intellisense configuration
......................................................................
Patch Set 1:
(1 comment)
Thank you for putting together a patch to address the issue.
I'm not an expert in IntelliJ, but I'm just trying to thing about possible alternative approaches.
http://gerrit.cloudera.org:8080/#/c/15155/1/java/README.adoc
File java/README.adoc:
http://gerrit.cloudera.org:8080/#/c/15155/1/java/README.adoc@143
PS1, Line 143: Some of the classes generated by Kudu Protobuf files are larger than the
: default "intellisense" limit in Intellij. This means Intellij won't
: provide code assistance for the classes in those files and may indicate
: that the classes in those files are not found. Follow the instructions
: https://intellij-support.jetbrains.com/hc/en-us/articles/206544869-Configuring-JVM-options-and-platform-properties[here]
: to set "idea.max.intellisense.filesize=5000" in the `idea.properties` file
: to work around this issue.
As an alternative approach, does it make sense to remove the protobuf auto-generated files from the list handled by intellisense somehow?
--
To view, visit http://gerrit.cloudera.org:8080/15155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Gerrit-Change-Number: 15155
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Feb 2020 00:13:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Document increasing Intellij intellisense configuration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15155 )
Change subject: [java] Document increasing Intellij intellisense configuration
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15155/1/java/README.adoc
File java/README.adoc:
http://gerrit.cloudera.org:8080/#/c/15155/1/java/README.adoc@143
PS1, Line 143: Some of the classes generated by Kudu Protobuf files are larger than the
: default "intellisense" limit in Intellij. This means Intellij won't
: provide code assistance for the classes in those files and may indicate
: that the classes in those files are not found. Follow the instructions
: https://intellij-support.jetbrains.com/hc/en-us/articles/206544869-Configuring-JVM-options-and-platform-properties[here]
: to set "idea.max.intellisense.filesize=5000" in the `idea.properties` file
: to work around this issue.
> I don't think so, it affects the usability of those classes.
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/15155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Gerrit-Change-Number: 15155
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Feb 2020 20:27:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Document increasing Intellij intellisense configuration
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15155 )
Change subject: [java] Document increasing Intellij intellisense configuration
......................................................................
[java] Document increasing Intellij intellisense configuration
Our Protobuf files generate Java classes that are too large for
Intellij to provide code assistance for by default.
This results in what appears to be missing classes and difficulty
working with the Protobuf classes.
I added a note under the Intellij section of the Java readme to help
others workaround this.
Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Reviewed-on: http://gerrit.cloudera.org:8080/15155
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/README.adoc
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Gerrit-Change-Number: 15155
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Document increasing Intellij intellisense configuration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15155 )
Change subject: [java] Document increasing Intellij intellisense configuration
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ed4fd9b838fb363a91aa08acae8e7dbb13939a
Gerrit-Change-Number: 15155
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Feb 2020 00:13:56 +0000
Gerrit-HasComments: No