You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2019/06/11 10:02:00 UTC

[jira] [Commented] (OFBIZ-11101) Refactor ComponentConfig

    [ https://issues.apache.org/jira/browse/OFBIZ-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860770#comment-16860770 ] 

Jacques Le Roux commented on OFBIZ-11101:
-----------------------------------------

All these patches look good to me, I just wonder if a sole patch would not be enough. Maybe to separate concerns when committing it's good though.

> Refactor ComponentConfig
> ------------------------
>
>                 Key: OFBIZ-11101
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11101
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-11101_0001-Rewrite-ComponentConfig-getAllClasspathInfo.patch, OFBIZ-11101_0002-Rewrite-ComponentConfig-getAllConfiguration.patch, OFBIZ-11101_0003-Rewrite-ComponentConfig-getAllKeystoreInfos.patch, OFBIZ-11101_0004-Rewrite-ComponentConfig-getAllServiceResour.patch, OFBIZ-11101_0005-Rewrite-ComponentConfig-getAllTestSuiteInfo.patch, OFBIZ-11101_0006-Rewrite-ComponentConfig-getAllWebappResourc.patch
>
>
> {{ComponentConfig}} contains a lot list processing which should be rewritten using streams.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)