[kudu] 03/03: mini-cluster: exclude libpcre for license check

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hahao pushed a commit to tag 1.12.0-RC1
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit ae919d457cda36d854f81732b34af2384441d436
Author: Hao Hao <ha...@cloudera.com>
AuthorDate: Wed Apr 15 14:38:26 2020 -0700

    mini-cluster: exclude libpcre for license check
    
    While building mini cluster binaries on centos7, I saw error message
    'unknown license: lib/libpcre.so.1' during license check on artifact.
    By running lddtree on the binary, I found out libpcre is introduced
    as transitive dependency
    
    libcurl.so.4 => /root/kudu/thirdparty/installed/uninstrumented/lib/libcurl.so.4
            libk5crypto.so.3 => /lib64/libk5crypto.so.3
                libkrb5support.so.0 => /lib64/libkrb5support.so.0
                    libselinux.so.1 => /lib64/libselinux.so.1
                        libpcre.so.1 => /lib64/libpcre.so.1
    
    This patch excludes 'libpcre' for license check to account for licensing
    information only relevant to the binary artifacts.
    
    Change-Id: I0fc69eaf57025b1ce2f7857808e60218dc4f2771
    Reviewed-on: http://gerrit.cloudera.org:8080/15738
    Tested-by: Kudu Jenkins
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
    (cherry picked from commit cd95fef01d19674a8c43784bc4f3cd0ef1f4b5ac)
    Reviewed-on: http://gerrit.cloudera.org:8080/15744
    Tested-by: Hao Hao <ha...@cloudera.com>
---
 build-support/mini-cluster/relocate_binaries_for_mini_cluster.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
index 21bed54..f3c0aad 100755
--- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
+++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
@@ -52,7 +52,9 @@ KEY_PATH = 'path'
 PAT_SASL_LIBPLAIN = re.compile(r'libplain')
 
 # Exclude libraries that are (L)GPL-licensed and libraries that are not
-# portable across Linux kernel versions.
+# portable across Linux kernel versions. One exception is 'libpcre', which
+# is BSD-licensed. It is excluded because it is a transitive dependency
+# introduced by 'libselinux'.
 PAT_LINUX_LIB_EXCLUDE = re.compile(r"""(libpthread|
                                         libc|
                                         libstdc\+\+|
@@ -66,6 +68,7 @@ PAT_LINUX_LIB_EXCLUDE = re.compile(r"""(libpthread|
                                         libcom_err|
                                         libdb-[\d.]+|
                                         libselinux|
+                                        libpcre|
                                         libtinfo
                                        )\.so""", re.VERBOSE)