[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5082: Plug in the new routing introduced in #5046

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #5082: Plug in the new routing introduced in #5046
URL: https://github.com/apache/incubator-pinot/pull/5082#discussion_r382737323
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/messages/SegmentRefreshMessage.java
 ##########
 @@ -19,52 +19,60 @@
 package org.apache.pinot.common.messages;
 
 import java.util.UUID;
+import org.apache.helix.ZNRecord;
 import org.apache.helix.model.Message;
 
 
 /**
- * This (helix) message is sent from the controller to the server when a request is received to refresh
+ * This (Helix) message is sent from the controller to brokers and servers when a request is received to refresh
  * an existing segment.
  *
- * There is one mandatory field in the message -- the CRC of the new segment.
+ * NOTE: Changing this class to include new fields is a change in the protocol, so the new fields must be made optional,
+ * and coded in such a way that either controller, broker or server may be upgraded first.
 
 Review comment:
   Can we update the javadoc to state the time boundary refresh is now done as part of SegmentRefreshMessage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org