You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/06 15:09:33 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #11592: [TIR] HoistExpression, generalization of HoistIfThenElse
Lunderberg opened a new pull request, #11592:
URL: https://github.com/apache/tvm/pull/11592
This is a generalized form of `HoistIfThenElse`, which can also hoist `Let` bindings and independent portions of conditional expressions, in addition to hoisting an entire conditional expression. This will be used in upcoming changes to separate compute loops into a slow loop that handles edge cases and a fast branchless loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #11592: [TIR] HoistExpression, generalization of HoistIfThenElse
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #11592:
URL: https://github.com/apache/tvm/pull/11592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a diff in pull request #11592: [TIR] HoistExpression, generalization of HoistIfThenElse
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on code in PR #11592:
URL: https://github.com/apache/tvm/pull/11592#discussion_r904995673
##########
include/tvm/tir/transform.h:
##########
@@ -363,6 +363,14 @@ TVM_DLL Pass PointerValueTypeRewrite();
*/
TVM_DLL Pass HoistIfThenElse();
+/*!
+ * \brief Hoist loop-invariant IfThenElse nodes to
Review Comment:
Thank you, and updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #11592: [TIR] HoistExpression, generalization of HoistIfThenElse
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11592:
URL: https://github.com/apache/tvm/pull/11592#issuecomment-1162246319
Merged from main now that #11646 is merged. Previous CI failures were due to inconsistent simplification of `ceil(log2(x))` on each side of an if/else block, which (hopefully) should resolve the remaining CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #11592: [TIR] HoistExpression, generalization of HoistIfThenElse
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11592:
URL: https://github.com/apache/tvm/pull/11592#issuecomment-1151344679
Current failures in `test_sort` are due to a `thread_extent` being provable on one side of a hoisted condition, but not on the other. These failures are resolved in #11646, which introduces simplifications for `ceil` and `log2`, along with bounds propagation of `operator<<`, so that the `thread_extent` is no longer a conflict.
Once #11646 is merged, will rebase this PR on top of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a diff in pull request #11592: [TIR] HoistExpression, generalization of HoistIfThenElse
Posted by GitBox <gi...@apache.org>.
vinx13 commented on code in PR #11592:
URL: https://github.com/apache/tvm/pull/11592#discussion_r890362091
##########
include/tvm/tir/transform.h:
##########
@@ -363,6 +363,14 @@ TVM_DLL Pass PointerValueTypeRewrite();
*/
TVM_DLL Pass HoistIfThenElse();
+/*!
+ * \brief Hoist loop-invariant IfThenElse nodes to
Review Comment:
update comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org