You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/14 16:58:05 UTC

[GitHub] cjolivier01 commented on a change in pull request #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by?

cjolivier01 commented on a change in pull request #8872: Minor refactor: prevent string copying, list -> vector, shared_ptr by?
URL: https://github.com/apache/incubator-mxnet/pull/8872#discussion_r157001880
 
 

 ##########
 File path: src/engine/thread_pool.h
 ##########
 @@ -122,7 +123,7 @@ class ThreadPool {
   /*!
    * \brief Startup synchronization objects
    */
-  std::list<std::shared_ptr<SimpleEvent>> ready_events_;
+  std::vector<std::shared_ptr<SimpleEvent> > ready_events_;
 
 Review comment:
   Why did you change to vector? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services