You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "sbglasius (via GitHub)" <gi...@apache.org> on 2025/06/04 13:55:17 UTC
[PR] Verify build explanation and minor fix [grails-core]
sbglasius opened a new pull request, #14781:
URL: https://github.com/apache/grails-core/pull/14781
Added explanation on how to find staging repo id, and fixed a current directory that was wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #14781:
URL: https://github.com/apache/grails-core/pull/14781#discussion_r2126683741
##########
etc/bin/verify-jar-artifacts.sh:
##########
@@ -56,6 +56,8 @@ error() {
}
trap error ERR
+cd "${DOWNLOAD_LOCATION}"
Review Comment:
Ah, I always had the download_location = current directory in my testing. Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #14781:
URL: https://github.com/apache/grails-core/pull/14781#discussion_r2126673842
##########
RELEASE.md:
##########
@@ -71,6 +71,8 @@ For Example:
verify.sh orgapachegrails-1030 v7.0.0-M4 /tmp/grails-verify
```
+The `staging repo id` can be found in awaiting https://github.com/apache/grails-core/actions/workflows/release.yml, click `publish`, open the stage `Create Staging Repository` and look for the line starting with `Created staging repository`
Review Comment:
[nitpick] The phrase 'in awaiting' is unclear; consider rephrasing to 'in' or 'under' the specified GitHub Actions workflow UI for clarity.
```suggestion
The `staging repo id` can be found under https://github.com/apache/grails-core/actions/workflows/release.yml, click `publish`, open the stage `Create Staging Repository` and look for the line starting with `Created staging repository`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on code in PR #14781:
URL: https://github.com/apache/grails-core/pull/14781#discussion_r2126684071
##########
RELEASE.md:
##########
@@ -71,6 +71,8 @@ For Example:
verify.sh orgapachegrails-1030 v7.0.0-M4 /tmp/grails-verify
```
+The `staging repo id` can be found in awaiting https://github.com/apache/grails-core/actions/workflows/release.yml, click `publish`, open the stage `Create Staging Repository` and look for the line starting with `Created staging repository`
Review Comment:
Yes, but if you're not committer, I assume it would also be possible to use my method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #14781:
URL: https://github.com/apache/grails-core/pull/14781#discussion_r2126675657
##########
RELEASE.md:
##########
@@ -71,6 +71,8 @@ For Example:
verify.sh orgapachegrails-1030 v7.0.0-M4 /tmp/grails-verify
```
+The `staging repo id` can be found in awaiting https://github.com/apache/grails-core/actions/workflows/release.yml, click `publish`, open the stage `Create Staging Repository` and look for the line starting with `Created staging repository`
Review Comment:
You can also login to repository.apache.org and just click "Staging Repositories" on the left side. That's how I've been doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #14781:
URL: https://github.com/apache/grails-core/pull/14781#discussion_r2126688398
##########
RELEASE.md:
##########
@@ -71,6 +71,8 @@ For Example:
verify.sh orgapachegrails-1030 v7.0.0-M4 /tmp/grails-verify
```
+The `staging repo id` can be found in awaiting https://github.com/apache/grails-core/actions/workflows/release.yml, click `publish`, open the stage `Create Staging Repository` and look for the line starting with `Created staging repository`
Review Comment:
Oh absolutely, I agree with your proposal for that reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #14781:
URL: https://github.com/apache/grails-core/pull/14781#issuecomment-2940148641
Please do not merge this until after M4 has been released since we're waiting on the vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Verify build explanation and minor fix [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #14781:
URL: https://github.com/apache/grails-core/pull/14781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org