You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by ah...@apache.org on 2016/10/06 09:33:02 UTC
zeppelin git commit: [MINOR] Rearrange the contents in "About
Zeppelin"
Repository: zeppelin
Updated Branches:
refs/heads/master a66b01998 -> de2d6e495
[MINOR] Rearrange the contents in "About Zeppelin"
### What is this PR for?
Just rearranged the placement of Zeppelin logo, title and text in "About Zeppelin". In the mobile screen as well.
### What type of PR is it?
Improvement
### What is the Jira issue?
No Jira issue for this
### How should this be tested?
To check this change in your local, build only `zeppelin-web` with `./grunt build` and then browse with `./grunt serve`.
### Screenshots (if appropriate)
- **Before**
1. desktop & tablet screen
<img src="https://cloud.githubusercontent.com/assets/10060731/18860571/8aa85aec-84b9-11e6-9112-b6869291f8f0.png" width="500px">
2. mobile screen
<img src="https://cloud.githubusercontent.com/assets/10060731/18860576/91f623a6-84b9-11e6-96ba-e34c43221143.png" width="300px">
- **After**
1. desktop & tablet screen
<img src="https://cloud.githubusercontent.com/assets/10060731/19140869/b5ab79e0-8bcb-11e6-946f-df63045e6f1e.png" width="500px">
2. mobile screen
<img src="https://cloud.githubusercontent.com/assets/10060731/19140879/c034b476-8bcb-11e6-977b-29deb6776f13.png" width="300px">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <ah...@apache.org>
Closes #1461 from AhyoungRyu/improve/aboutZeppelin and squashes the following commits:
16421c9 [AhyoungRyu] Add a newline
a8628c8 [AhyoungRyu] Apply responsive design
81ef021 [AhyoungRyu] Rearrange 'About Zeppelin'
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/de2d6e49
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/de2d6e49
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/de2d6e49
Branch: refs/heads/master
Commit: de2d6e4956d5a6535628742c373e65c54891ee02
Parents: a66b019
Author: AhyoungRyu <ah...@apache.org>
Authored: Thu Oct 6 13:51:10 2016 +0900
Committer: AhyoungRyu <ah...@apache.org>
Committed: Thu Oct 6 18:32:53 2016 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/home/home.css | 27 ++++++++++++---------
zeppelin-web/src/components/navbar/navbar.html | 6 ++---
2 files changed, 18 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/de2d6e49/zeppelin-web/src/app/home/home.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/home/home.css b/zeppelin-web/src/app/home/home.css
index 8b37eb8..a2fe81c 100644
--- a/zeppelin-web/src/app/home/home.css
+++ b/zeppelin-web/src/app/home/home.css
@@ -804,24 +804,27 @@ This part should be removed when new version of bootstrap handles this issue.
background: #3071a9;
}
-.about{
+/* About Zeppelin */
+.about {
height: 200px;
- padding-top: 20px;
- padding-left: 20px;
+ padding: 25px;
}
.about .logo {
- width: 20%;
- float: left;
+ padding-top: 30px;
}
-.about .content{
- float: left;
- padding-left: 10px;
- top: -30px;
- position: relative;
+.about .logo img {
+ width: 95%;
}
-.about .logo img{
- width: 100%;
+.about .content {
+ text-align: center;
+}
+
+.about .content h3 {
+ font-family: 'Patua One';
+ color: #3071A9;
+ font-size: 30px;
+ margin: 0 auto;
}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/de2d6e49/zeppelin-web/src/components/navbar/navbar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.html b/zeppelin-web/src/components/navbar/navbar.html
index 109e328..0e64ad4 100644
--- a/zeppelin-web/src/components/navbar/navbar.html
+++ b/zeppelin-web/src/components/navbar/navbar.html
@@ -114,11 +114,11 @@ limitations under the License.
</div>
<div class="modal-body">
- <div class="about">
- <div class="logo">
+ <div class="row about">
+ <div class="hidden-xs col-sm-4 col-md-4 logo">
<img src="assets/images/zepLogo.png" alt="Apache Zeppelin" title="Apache Zeppelin" />
</div>
- <div class="content">
+ <div class="col-xs-12 col-sm-8 col-md-8 content">
<h3>Apache Zeppelin</h3>
<br/>
<span id="i18n-14">Version</span>