You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/20 07:48:08 UTC
[GitHub] [apisix-dashboard] ericsyh opened a new issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
ericsyh opened a new issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803
## Issue description
<!-- A clear and concise description of what the issue is. -->
When fixing the Upstream form warning message issue, i found a behavior that users can delete all target nodes forms on the page like
But this upstream can be created successfully.
## Expected behavior
<!-- A clear and concise description of what you expected to happen. -->
Not sure is it a expected behavior.
## How to Reproduce
1. Go to 'Upstream Page'
2. Click on 'Create Button'
3. Delete all targets nodes forms
## Screenshots
<!-- Add screenshots to help explain your problem if applicable. -->
## Environment
* apisix version (cmd: `apisix version`): the master branch
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
* Browser version, if have:
## Additional context
<!-- Do you want to solve this issue? or add any other context about the problem here. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823768235
+1 for keeping the current behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-826252015
close now. If you have any question, welcome reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou edited a comment on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
Firstsawyou edited a comment on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824505125
> > ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list?
>
> @Firstsawyou any scenarios when users create an upstream with empty nodes?
I have not encountered this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823680775
As @liuxiran said, we actually support an empty node list, it will return a 5xx status code to the client. I would prefer keeping the current behaviour, because if users really want to do it, what they can do on the dashboard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824442184
+1 for keeping the current behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824096002
> ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list?
@Firstsawyou any scenarios when users create an upstream with empty nodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-826252015
close now. If you have any question, welcome reopen it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-825358536
> > > ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list?
> >
> >
> > @Firstsawyou any scenarios when users create an upstream with empty nodes?
>
> I have not encountered this situation.
I think in some test situations. Users use the `echo plugin` to return responses. So they don't need any upstream nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ericsyh edited a comment on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
ericsyh edited a comment on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823798761
ok for close the issue. But i am quite interesting in what scenario that users will create an upstream with empty node list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823786050
@juzhiyuan @nic-chen keep the current behavior is also reasonable for me
If there is no objection, we will close the issue
cc @ericsyh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-824505125
> > ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list?
>
> @Firstsawyou any scenarios when users create an upstream with empty nodes?
I have not encountered this situation. Setting the upstream with empty node, it seems that there is no usage scenario.
I will create an issue on the backend to discuss it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ericsyh commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
ericsyh commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823798761
ok for close the issue. But i am quite interesting in what scenario that users will create a upstream with empty node list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-823120920
Hi @ericsyh thanks for your report.
Acctually from the funcitonal point of view, the empty node list is a feature, see:
`The nodes can be empty, which means it is a placeholder and will be filled later. Clients use such an upstream will get 502 response.`
(come from https://github.com/apache/apisix/blob/master/docs/en/latest/admin-api.md#upstream)
But from the UE point of view, an upstream can not be used with the empty node list, so keep at least one node in the node list is better.
How about add this restriction to the dashboard?
Let's wait for others option @juzhiyuan @LiteSun @nic-chen @imjoey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1803: Question: is it a bug that users can delete all target nodes forms in upstream create page?
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1803:
URL: https://github.com/apache/apisix-dashboard/issues/1803#issuecomment-825008616
Then how about leave enough space for users, that is to say, we just keep the current behavior, when users have scenarios that create an upstream with no nodes(even if we have not encountered now), they can do this through dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org