You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/23 06:49:03 UTC
[GitHub] [apisix] navendu-pottekkat opened a new pull request, #7312: docs: update "Other protocols" Plugins
navendu-pottekkat opened a new pull request, #7312:
URL: https://github.com/apache/apisix/pull/7312
Signed-off-by: Navendu Pottekkat <na...@gmail.com>
### Description
Updates the documentation of the "Other protocols" Plugins.
Child PR of #6734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r907386850
##########
docs/en/latest/plugins/dubbo-proxy.md:
##########
@@ -23,40 +30,39 @@ title: dubbo-proxy
## Description
-dubbo-proxy plugin allows you proxy HTTP request to [**dubbo**](http://dubbo.apache.org).
+The `dubbo-proxy` Plugin allows you to proxy HTTP requests to [Apache Dubbo](https://dubbo.apache.org/en/index.html).
+
+:::info IMPORTANT
-## Requirement
+If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment) for details.
Review Comment:
@hf400159 The "?" does not come in the URL it seems... See: https://apisix.apache.org/docs/apisix/FAQ#how-do-i-build-the-apisix-base-environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
navendu-pottekkat commented on PR #7312:
URL: https://github.com/apache/apisix/pull/7312#issuecomment-1167351163
Thank you @okaybase and @hf400159
I have made the changes as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #7312:
URL: https://github.com/apache/apisix/pull/7312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r906667807
##########
docs/en/latest/plugins/dubbo-proxy.md:
##########
@@ -23,40 +30,39 @@ title: dubbo-proxy
## Description
-dubbo-proxy plugin allows you proxy HTTP request to [**dubbo**](http://dubbo.apache.org).
+The `dubbo-proxy` Plugin allows you to proxy HTTP requests to [Apache Dubbo](https://dubbo.apache.org/en/index.html).
+
+:::info IMPORTANT
-## Requirement
+If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment) for details.
Review Comment:
```suggestion
If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment?) for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
okaybase commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r906667477
##########
docs/en/latest/plugins/dubbo-proxy.md:
##########
@@ -23,40 +30,39 @@ title: dubbo-proxy
## Description
-dubbo-proxy plugin allows you proxy HTTP request to [**dubbo**](http://dubbo.apache.org).
+The `dubbo-proxy` Plugin allows you to proxy HTTP requests to [Apache Dubbo](https://dubbo.apache.org/en/index.html).
+
+:::info IMPORTANT
-## Requirement
+If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment) for details.
-If you are using OpenResty, you need to build it with dubbo support, see [APISIX-Base](./FAQ/#how-do-i-build-the-apisix-base-environment).
+:::
## Runtime Attributes
-| Name | Type | Requirement | Default | Valid | Description |
-| ------------ | ------ | ----------- | -------- | ------------ | -------------------------------------------------------------------- |
-| service_name | string | required | | | dubbo provider service name|
-| service_version | string | required | | | dubbo provider service version|
-| method | string | optional | the path of uri | | dubbo provider service method|
+| Name | Type | Required | Default | Description |
+| --------------- | ------ | -------- | -------------------- | ------------------------------- |
+| service_name | string | required | | Dubbo provider service name. |
+| service_version | string | required | | Dubbo provider service version. |
+| method | string | optional | The path of the URI. | Dubbo provider service method. |
Review Comment:
```suggestion
| method | string | False | The path of the URI. | Dubbo provider service method. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
okaybase commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r906667456
##########
docs/en/latest/plugins/dubbo-proxy.md:
##########
@@ -23,40 +30,39 @@ title: dubbo-proxy
## Description
-dubbo-proxy plugin allows you proxy HTTP request to [**dubbo**](http://dubbo.apache.org).
+The `dubbo-proxy` Plugin allows you to proxy HTTP requests to [Apache Dubbo](https://dubbo.apache.org/en/index.html).
+
+:::info IMPORTANT
-## Requirement
+If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment) for details.
-If you are using OpenResty, you need to build it with dubbo support, see [APISIX-Base](./FAQ/#how-do-i-build-the-apisix-base-environment).
+:::
## Runtime Attributes
-| Name | Type | Requirement | Default | Valid | Description |
-| ------------ | ------ | ----------- | -------- | ------------ | -------------------------------------------------------------------- |
-| service_name | string | required | | | dubbo provider service name|
-| service_version | string | required | | | dubbo provider service version|
-| method | string | optional | the path of uri | | dubbo provider service method|
+| Name | Type | Required | Default | Description |
+| --------------- | ------ | -------- | -------------------- | ------------------------------- |
+| service_name | string | required | | Dubbo provider service name. |
+| service_version | string | required | | Dubbo provider service version. |
Review Comment:
```suggestion
| service_version | string | True | | Dubbo provider service version. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r905019382
##########
docs/en/latest/plugins/mqtt-proxy.md:
##########
@@ -57,9 +61,9 @@ For example, the following configuration represents listening on the 9100 TCP po
...
```
-Then send the MQTT request to port 9100.
+You can now send the MQT request to port `9100`.
Review Comment:
```suggestion
You can now send the MQTT request to port `9100`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
okaybase commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r906667564
##########
docs/en/latest/plugins/dubbo-proxy.md:
##########
@@ -23,40 +30,39 @@ title: dubbo-proxy
## Description
-dubbo-proxy plugin allows you proxy HTTP request to [**dubbo**](http://dubbo.apache.org).
+The `dubbo-proxy` Plugin allows you to proxy HTTP requests to [Apache Dubbo](https://dubbo.apache.org/en/index.html).
+
+:::info IMPORTANT
-## Requirement
+If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment) for details.
-If you are using OpenResty, you need to build it with dubbo support, see [APISIX-Base](./FAQ/#how-do-i-build-the-apisix-base-environment).
+:::
## Runtime Attributes
-| Name | Type | Requirement | Default | Valid | Description |
-| ------------ | ------ | ----------- | -------- | ------------ | -------------------------------------------------------------------- |
-| service_name | string | required | | | dubbo provider service name|
-| service_version | string | required | | | dubbo provider service version|
-| method | string | optional | the path of uri | | dubbo provider service method|
+| Name | Type | Required | Default | Description |
+| --------------- | ------ | -------- | -------------------- | ------------------------------- |
+| service_name | string | required | | Dubbo provider service name. |
+| service_version | string | required | | Dubbo provider service version. |
+| method | string | optional | The path of the URI. | Dubbo provider service method. |
## Static Attributes
-| Name | Type | Requirement | Default | Valid | Description |
-| ------------ | ------ | ----------- | -------- | ------------ | -------------------------------------------------------------------- |
-| upstream_multiplex_count | number | required | 32 | >= 1 | the maximum number of multiplex requests in an upstream connection |
+| Name | Type | Required | Default | Valid values | Description |
+| ------------------------ | ------ | -------- | ------- | ------------ | --------------------------------------------------------------- |
+| upstream_multiplex_count | number | required | 32 | >= 1 | Maximum number of multiplex requests in an upstream connection. |
Review Comment:
```suggestion
| upstream_multiplex_count | number | True | 32 | >= 1 | Maximum number of multiplex requests in an upstream connection. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a diff in pull request #7312: docs: update "Other protocols" Plugins
Posted by GitBox <gi...@apache.org>.
okaybase commented on code in PR #7312:
URL: https://github.com/apache/apisix/pull/7312#discussion_r906667301
##########
docs/en/latest/plugins/dubbo-proxy.md:
##########
@@ -23,40 +30,39 @@ title: dubbo-proxy
## Description
-dubbo-proxy plugin allows you proxy HTTP request to [**dubbo**](http://dubbo.apache.org).
+The `dubbo-proxy` Plugin allows you to proxy HTTP requests to [Apache Dubbo](https://dubbo.apache.org/en/index.html).
+
+:::info IMPORTANT
-## Requirement
+If you are using OpenResty, you need to build it with Dubbo support. See [How do I build the APISIX base environment](./../FAQ.md#how-do-i-build-the-apisix-base-environment) for details.
-If you are using OpenResty, you need to build it with dubbo support, see [APISIX-Base](./FAQ/#how-do-i-build-the-apisix-base-environment).
+:::
## Runtime Attributes
-| Name | Type | Requirement | Default | Valid | Description |
-| ------------ | ------ | ----------- | -------- | ------------ | -------------------------------------------------------------------- |
-| service_name | string | required | | | dubbo provider service name|
-| service_version | string | required | | | dubbo provider service version|
-| method | string | optional | the path of uri | | dubbo provider service method|
+| Name | Type | Required | Default | Description |
+| --------------- | ------ | -------- | -------------------- | ------------------------------- |
+| service_name | string | required | | Dubbo provider service name. |
Review Comment:
```suggestion
| service_name | string | True | | Dubbo provider service name. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org