[GitHub] [ignite-3] alievmirza commented on a change in pull request #674: IGNITE-16010 move setBaseline to cluster configuration

[GitBox <gi...@apache.org>]

alievmirza commented on a change in pull request #674:
URL: https://github.com/apache/ignite-3/pull/674#discussion_r822723228



##########
File path: modules/baseline/src/main/java/org/apache/ignite/internal/baseline/BaselineManager.java
##########
@@ -31,32 +38,29 @@
 // TODO: https://issues.apache.org/jira/browse/IGNITE-14716 Adapt concept of baseline topology IEP-4.
 @SuppressWarnings({"FieldCanBeLocal", "unused"})
 public class BaselineManager implements IgniteComponent {
-    /** Configuration manager in order to handle and listen baseline specific configuration. */
-    private final ConfigurationManager configurationMgr;
-
-    /**
-     * MetaStorage manager in order to watch private distributed baseline specific configuration, cause ConfigurationManger handles only
-     * public configuration.
-     */
-    private final MetaStorageManager metastorageMgr;
+    /** Cluster configuration in order to handle and listen baseline specific configuration. */
+    private final ClusterConfiguration clusterConfiguration;
 
     /** Cluster network service in order to retrieve information about current cluster nodes. */
     private final ClusterService clusterSvc;
 
+    /** Busy lock to stop synchronously. */
+    private final IgniteSpinBusyLock busyLock = new IgniteSpinBusyLock();
+
+    /** Prevents double stopping the component. */
+    AtomicBoolean stopGuard = new AtomicBoolean();

Review comment:
       it is possible, that for some tests we can stop some components manually, so it is better to have this guard to prevent repeated stops.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org