You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/17 03:14:41 UTC
[GitHub] [kafka] wenbingshen opened a new pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest
wenbingshen opened a new pull request #10551:
URL: https://github.com/apache/kafka/pull/10551
As the title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen commented on a change in pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on a change in pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#discussion_r615229878
##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -736,7 +735,6 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
topicService.describeTopic(new TopicCommandOptions(Array("--topic", testTopicName))))
val rows = output.split("\n")
assertEquals(2, rows.size)
- rows(0).startsWith(s"Topic:$testTopicName\tPartitionCount:1")
Review comment:
Thanks for your commont. Due to the introduction of topicId, this will cause assert to fail. We can’t get the topicId in advance, so we can use `assertTrue(rows(0).startsWith(s"\tTopic: $testTopicName"))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen commented on pull request #10551: MINOR: Fix nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#issuecomment-823076892
> @wenbingshen thanks for your patch. LGTM
>
> Could you revise the title of this PR? I'd like to merge it tomorrow.
I think the failed test is unrelated to this PR, request to be merged into the trunk. Thanks. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen commented on pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#issuecomment-822208422
> @wenbingshen thanks for your patch. LGTM
>
> Could you revise the title of this PR? I'd like to merge it tomorrow.
Of course, I will modify it now, thank you for your review. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen commented on pull request #10551: MINOR: Fix nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#issuecomment-822973514
Merge trunk to trigger QA again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #10551: MINOR: Fix nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10551:
URL: https://github.com/apache/kafka/pull/10551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wenbingshen commented on a change in pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on a change in pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#discussion_r615547868
##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -465,7 +465,7 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
topicService.describeTopic(new TopicCommandOptions(Array("--topic", testTopicName))))
val rows = output.split("\n")
assertEquals(3, rows.size)
- assertTrue(rows(0).startsWith(s"\tTopic: $testTopicName"))
+ assertTrue(rows(0).startsWith(s"Topic: $testTopicName"))
Review comment:
Replace `assertTrue(rows(0).startsWith(s"Topic:$testTopicName\tPartitionCount:1"))` with `assertTrue(rows(0).startsWith(s"Topic: $testTopicName"))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10551: MINOR:Remove nonsense test line from TopicCommandTest
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10551:
URL: https://github.com/apache/kafka/pull/10551#discussion_r615220275
##########
File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -736,7 +735,6 @@ class TopicCommandWithAdminClientTest extends KafkaServerTestHarness with Loggin
topicService.describeTopic(new TopicCommandOptions(Array("--topic", testTopicName))))
val rows = output.split("\n")
assertEquals(2, rows.size)
- rows(0).startsWith(s"Topic:$testTopicName\tPartitionCount:1")
Review comment:
Maybe `assertTrue(rows(0).startsWith(s"Topic:$testTopicName\tPartitionCount:1"))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org