[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42550: [SPARK-44861][CONNECT] jsonignore SparkListenerConnectOperationStarted.planRequest

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on code in PR #42550:
URL: https://github.com/apache/spark/pull/42550#discussion_r1298276465


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala:
##########
@@ -278,6 +278,7 @@ case class ExecuteEventsManager(executeHolder: ExecuteHolder, clock: Clock) {
  * @param extraTags:
  *   Additional metadata during the request.
  */
+@JsonIgnoreProperties({ "planRequest" })

Review Comment:
   @gengliangwang @rednaxelafx does something need to be done so that history service defaults None on this planRequest missing from json, or will this just work?
   Are there any suites where event log replay from json is tested where a test could be added for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org