You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/08 02:33:50 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #8114: KAFKA-9290: Update IQ related JavaDocs

mjsax commented on a change in pull request #8114:
URL: https://github.com/apache/kafka/pull/8114#discussion_r421902436



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##########
@@ -212,7 +212,7 @@
      * {@link KafkaStreams#store(StoreQueryParameters) KafkaStreams#store(...)}:
      * <pre>{@code
      * KafkaStreams streams = ...
-     * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>>timestampedKeyValueStore());
+     * ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore = streams.store(queryableStoreName, QueryableStoreTypes.<K, ValueAndTimestamp<V>> timestampedKeyValueStore());

Review comment:
       I think @ableegoldman meant in the return type:
   ```
   ReadOnlyKeyValueStore<K,ValueAndTimestamp<V>> localStore
   // -> should be
   ReadOnlyKeyValueStore<K, ValueAndTimestamp<V>> localStore
   ```
   
   The space you inserted should _not_ be there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org