You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/13 10:52:21 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #6028: libc:xtensa: move syscall to swint call

Ouss4 commented on code in PR #6028:
URL: https://github.com/apache/incubator-nuttx/pull/6028#discussion_r849347233


##########
libs/libc/machine/xtensa/arch_setjmp.S:
##########
@@ -127,8 +129,10 @@ setjmp:
 
   /* Flush registers.  */
   mov a4, a2      # save a2 (jmp_buf)
-  movi  a2, 0
-  syscall
+  movi  a2, SYS_flush_context

Review Comment:
   Are any of these commands handled by the software interrupt?
   
   Speaking of `setjmp`, please note that the current `longjmp` implementation can cause issues for code using `WINBASE` and `WINSTART` as they are not saved.  for ESP-IDF there is a patch here: https://github.com/espressif/esp-idf/blob/4350e6fef859b94f3efae6ceced751911c9d2cbc/components/esp_rom/patches/esp_rom_longjmp.S#L43-L59



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org