You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/11/10 17:11:43 UTC

[GitHub] [tomee] sultan commented on a diff in pull request #963: [TOMEE-4053] Dependency properties cleanup, step 4 on branch 8.x

sultan commented on code in PR #963:
URL: https://github.com/apache/tomee/pull/963#discussion_r1019408847


##########
server/openejb-cxf/pom.xml:
##########
@@ -264,7 +264,7 @@
     <dependency>
       <groupId>com.sun.xml.messaging.saaj</groupId>
       <artifactId>saaj-impl</artifactId>
-      <version>${saaj-impl.version}</version>
+      <version>${version.impl.saaj}</version>

Review Comment:
   The intent was to have all future ambiguous impl in a "version.impl" prefix like version.impl.activation and version.impl.mail to disambiguate with api version with prefixes without impl. There should be ambiguity only with those three. It can be changed to something else entirely if needed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org