You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/04 21:22:51 UTC

[GitHub] [trafficserver] randall commented on a change in pull request #7782: Short circuit remap reload when a valid remap file is not specified

randall commented on a change in pull request #7782:
URL: https://github.com/apache/trafficserver/pull/7782#discussion_r626116582



##########
File path: proxy/ReverseProxy.cc
##########
@@ -67,7 +67,7 @@ init_reverse_proxy()
 
   Note("%s loading ...", ts::filename::REMAP);
   if (!rewrite_table->load()) {
-    Fatal("%s failed to load", ts::filename::REMAP);
+    Warning("%s failed to load", ts::filename::REMAP);

Review comment:
       should we return early here? So we don't see a "finished loading" in the failure case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org