You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/23 00:02:44 UTC
[kudu-CR] move data gen util to integration-tests
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14532
Change subject: move data_gen_util to integration-tests
......................................................................
move data_gen_util to integration-tests
I want it in client-test and a client -> tools dependency feels awkward.
Change-Id: I4895f66ffff940c9215f948512f783d44cf1d924
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/data_gen_util.cc
R src/kudu/integration-tests/data_gen_util.h
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/ts_sentry-itest.cc
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote-test.cc
8 files changed, 13 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/14532/1
--
To view, visit http://gerrit.cloudera.org:8080/14532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4895f66ffff940c9215f948512f783d44cf1d924
Gerrit-Change-Number: 14532
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] move data gen util to integration-tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14532 )
Change subject: move data_gen_util to integration-tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4895f66ffff940c9215f948512f783d44cf1d924
Gerrit-Change-Number: 14532
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Oct 2019 02:52:25 +0000
Gerrit-HasComments: No
[kudu-CR] move data gen util to integration-tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14532 )
Change subject: move data_gen_util to integration-tests
......................................................................
move data_gen_util to integration-tests
I want it in client-test and a client -> tools dependency feels awkward.
Change-Id: I4895f66ffff940c9215f948512f783d44cf1d924
Reviewed-on: http://gerrit.cloudera.org:8080/14532
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/data_gen_util.cc
R src/kudu/integration-tests/data_gen_util.h
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/ts_sentry-itest.cc
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote-test.cc
8 files changed, 13 insertions(+), 22 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4895f66ffff940c9215f948512f783d44cf1d924
Gerrit-Change-Number: 14532
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)