You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/17 17:07:48 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #13802: [BEAM-1474]. Adding MapState and SetState support for the Dataflow runner

boyuanzz commented on a change in pull request #13802:
URL: https://github.com/apache/beam/pull/13802#discussion_r577788012



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -2236,20 +2234,6 @@ static void verifyDoFnSupportedStreaming(DoFn<?, ?> fn) {
   }
 
   static void verifyDoFnSupported(DoFn<?, ?> fn, boolean streaming) {
-    if (DoFnSignatures.usesSetState(fn)) {

Review comment:
       We should still throw exceptions when using runner v2. Could you please add this check back for runner_v2? @reuvenlax 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org