You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/01/27 00:16:20 UTC
[kudu-CR] WIP: Support for enabling webserver SSL in CSD
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5806
Change subject: WIP: Support for enabling webserver SSL in CSD
......................................................................
WIP: Support for enabling webserver SSL in CSD
Needs to be tested, etc. I had this hangoung around in a local branch
and wanted to push it up.
Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa
---
M java/kudu-csd/src/descriptor/service.sdl
M java/pom.xml
2 files changed, 27 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/5806/1
--
To view, visit http://gerrit.cloudera.org:8080/5806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP: Support for enabling webserver SSL in CSD
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: WIP: Support for enabling webserver SSL in CSD
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5806/1/java/kudu-csd/src/descriptor/service.sdl
File java/kudu-csd/src/descriptor/service.sdl:
Line 174: "sslServer": {
If I'm understanding this correctly, this generates ssl_enabled, webserver_private_key_file, webserver_certificate_file, and webserver_private_key_password_cmd parameters. All but the first are included in the gflagfile. I presume this also affects the "externalLink" section, such that https:// links are generated?
BTW, one piece of feedback we've received in the past is to unify master/tserver params under the service itself where possible. Can we do that for sslServer? Or must it be defined at the role level?
If the latter, we may need to namespace the parameters with "master_" or "tserver_" prefixes to avoid collisions; I'm not 100% sure.
--
To view, visit http://gerrit.cloudera.org:8080/5806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] WIP: Support for enabling webserver SSL in CSD
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: WIP: Support for enabling webserver SSL in CSD
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5806/1/java/kudu-csd/src/descriptor/service.sdl
File java/kudu-csd/src/descriptor/service.sdl:
Line 174: "sslServer": {
> If I'm understanding this correctly, this generates ssl_enabled, webserver_
A few quick follow-ups:
- We can't unify these; they must be per-role.
- We don't need to add master_/tserver_ prefixes, as these aren't the in-database parameter names; they're just the emitted config names.
--
To view, visit http://gerrit.cloudera.org:8080/5806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] WIP: Support for enabling webserver SSL in CSD
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.
Change subject: WIP: Support for enabling webserver SSL in CSD
......................................................................
Abandoned
The CSD has been removed from the kudu repo, so removing this review
--
To view, visit http://gerrit.cloudera.org:8080/5806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins