You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/06/01 13:27:32 UTC

[GitHub] [arrow] westonpace commented on issue #35584: [Python] Creating integer array with floating value succeeds

westonpace commented on issue #35584:
URL: https://github.com/apache/arrow/issues/35584#issuecomment-1572053839

   > Note that, although this is indeed "reimplemented" in the pyarrow conversion code, this implementation is consistent with the casting code in C++.
   And whether this "check if value is withing fixed range" is the desired behaviour, or we want to relax this to larger ints that are representable as float, that's a discussion for https://github.com/apache/arrow/issues/35563
   
   @jorisvandenbossche 
   
   I'm not sure it is consistent. Note that the original discussion here is not about "large values that are outside the range of safely representable doubles" but about "is truncation `safe`?"
   
   https://github.com/apache/arrow/issues/35584#issuecomment-1553619744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org