You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Revolyssup (via GitHub)" <gi...@apache.org> on 2025/07/07 08:28:40 UTC
[PR] feat: add a global switch to disable upstream health check [apisix]
Revolyssup opened a new pull request, #12407:
URL: https://github.com/apache/apisix/pull/12407
### Description
When the user's production service is unavailable, users urgently need a way to quickly start the emergency APISIX service by turning off all health check functions with a single click.
### Solution
Add a new field apisix.disable_upstream_healthcheck to globally disable the healthchecks
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add a global switch to disable upstream health check [apisix]
Posted by "nic-6443 (via GitHub)" <gi...@apache.org>.
nic-6443 commented on code in PR #12407:
URL: https://github.com/apache/apisix/pull/12407#discussion_r2189597060
##########
apisix/cli/schema.lua:
##########
@@ -254,6 +254,11 @@ local config_schema = {
},
}
},
+ disable_upstream_healthcheck = {
Review Comment:
add this new configuration to `config.yaml.example`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add a global switch to disable upstream health check [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on code in PR #12407:
URL: https://github.com/apache/apisix/pull/12407#discussion_r2189605170
##########
apisix/cli/schema.lua:
##########
@@ -254,6 +254,11 @@ local config_schema = {
},
}
},
+ disable_upstream_healthcheck = {
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add a global switch to disable upstream health check [apisix]
Posted by "membphis (via GitHub)" <gi...@apache.org>.
membphis commented on code in PR #12407:
URL: https://github.com/apache/apisix/pull/12407#discussion_r2196310085
##########
apisix/upstream.lua:
##########
@@ -103,6 +103,11 @@ _M.get_healthchecker_name = get_healthchecker_name
local function create_checker(upstream)
+ local local_conf = require("apisix.core.config_local").local_conf()
Review Comment:
performance:
cache the `require("apisix.core.config_local")` at top level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add a global switch to disable upstream health check [apisix]
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup merged PR #12407:
URL: https://github.com/apache/apisix/pull/12407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org