You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "qq925716471 (GitHub)" <gi...@apache.org> on 2019/08/21 02:52:46 UTC

[GitHub] [dubbo] qq925716471 opened pull request #4901: fix issues3546

## What is the purpose of the change
fix bug #3546 
## Brief changelog
 Override writeRequestBody method, get method timeout parameter set to connection read timeout

## Verifying this change

see method testMethodTimeOut

Follow this checklist to help us incorporate your contribution quickly and easily:

+ [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
+ [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
+ [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
+ [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
+ [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/4901 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [dubbo] chickenlj closed pull request #4901: [Dubbo-3546] fix dubbo Http协议.timeout参数配置不生效 #3546

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]

[ Full content available at: https://github.com/apache/dubbo/pull/4901 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org