[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#discussion_r499922327



##########
File path: pkg/common/resources/resources.go
##########
@@ -792,7 +792,7 @@ func CalculateAbsUsedCapacity(capacity, used *Resource) *Resource {
 				absResValue = math.MinInt64
 			}
 		} else {
-			log.Logger().Warn("Cannot calculate absolute usage for resource because of missing usage information",
+			log.Logger().Info("Cannot calculate absolute usage for resource because of missing usage information",

Review comment:
       Today, we are reporting back all resource types, so we constantly see these lines because resource types "pods", "vcore", "ephemeral-storage", "hugepages-1Gi" etc are not tracked in the scheduler. So setting at INFO level won't seem to be enough for this. I'd suggest removing this line.
   Or we will need some mechanism to do white-listed resource names, that will introduce bigger changes for which I don't think it is necessary for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org