You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "fishy (via GitHub)" <gi...@apache.org> on 2023/12/04 21:43:27 UTC
[PR] Github Actions: Make java spotless step optional [thrift]
fishy opened a new pull request, #2898:
URL: https://github.com/apache/thrift/pull/2898
Add `continue-on-error: true` so it does not block cross-tests from running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Github Actions: Make java spotless step optional [thrift]
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2898:
URL: https://github.com/apache/thrift/pull/2898#issuecomment-1839864134
> > Add `continue-on-error: true` so it does not block cross-tests from running.
>
> wonder why it broke the cross-tests runs?
because cross tests depend on all other tests to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Github Actions: Make java spotless step optional [thrift]
Posted by "Jimexist (via GitHub)" <gi...@apache.org>.
Jimexist commented on PR #2898:
URL: https://github.com/apache/thrift/pull/2898#issuecomment-1839855829
> Add `continue-on-error: true` so it does not block cross-tests from running.
wonder why it broke the cross-tests runs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Github Actions: Make java spotless step optional [thrift]
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2898:
URL: https://github.com/apache/thrift/pull/2898#issuecomment-1839546354
ok this doesn't work, it breaks the whole gradle so java build is also broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Github Actions: Make java spotless step optional [thrift]
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy closed pull request #2898: Github Actions: Make java spotless step optional
URL: https://github.com/apache/thrift/pull/2898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org