You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ashish Vaidya <as...@yahoo.com> on 2012/12/18 03:23:52 UTC
Re: Review Request: [OOZIE-1137] - JavaActionExecutor.java addShareLib()
should use actionLibPath instead of appPath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8661/
-----------------------------------------------------------
(Updated Dec. 18, 2012, 2:23 a.m.)
Review request for oozie, Mohammad Islam, Alejandro Abdelnur, Mona Chitnis, Virag Kothari, and Rohini Palaniswamy.
Changes
-------
Added JIRA number.
Summary (updated)
-----------------
[OOZIE-1137] - JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath
Description
-------
In JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath so that IllegalArgumentException is not thrown in a federated setup.
This addresses bug OOZIE-1137.
https://issues.apache.org/jira/browse/OOZIE-1137
Diffs
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1423065
Diff: https://reviews.apache.org/r/8661/diff/
Testing
-------
Thanks,
Ashish Vaidya
Re: Review Request: [OOZIE-1137] - JavaActionExecutor.java addShareLib()
should use actionLibPath instead of appPath
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8661/#review14674
-----------------------------------------------------------
Ship it!
+1 non binding.
- Rohini Palaniswamy
On Dec. 18, 2012, 5:22 p.m., Ashish Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8661/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 5:22 p.m.)
>
>
> Review request for oozie, Mohammad Islam, Alejandro Abdelnur, Mona Chitnis, Virag Kothari, and Rohini Palaniswamy.
>
>
> Description
> -------
>
> In JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath so that IllegalArgumentException is not thrown in a federated setup.
>
>
> This addresses bug OOZIE-1137.
> https://issues.apache.org/jira/browse/OOZIE-1137
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1423534
>
> Diff: https://reviews.apache.org/r/8661/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Vaidya
>
>
Re: Review Request: [OOZIE-1137] - JavaActionExecutor.java addShareLib()
should use actionLibPath instead of appPath
Posted by Ashish Vaidya <as...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8661/
-----------------------------------------------------------
(Updated Dec. 18, 2012, 5:22 p.m.)
Review request for oozie, Mohammad Islam, Alejandro Abdelnur, Mona Chitnis, Virag Kothari, and Rohini Palaniswamy.
Changes
-------
Rolled back condition inversions...
Description
-------
In JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath so that IllegalArgumentException is not thrown in a federated setup.
This addresses bug OOZIE-1137.
https://issues.apache.org/jira/browse/OOZIE-1137
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1423534
Diff: https://reviews.apache.org/r/8661/diff/
Testing
-------
Thanks,
Ashish Vaidya
Re: Review Request: [OOZIE-1137] - JavaActionExecutor.java addShareLib()
should use actionLibPath instead of appPath
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On Dec. 18, 2012, 2:36 p.m., Alejandro Abdelnur wrote:
> > patch looks good except for the 2 comments on 'condition inversion' changes.
> >
> > 1* Those changes are not related to this patch
> > 2* The current behavior is correct
> > 3* With the current IF logic the method has a single exit point, the end of the method, that is preferable.
> >
>
> Ashish Vaidya wrote:
> I was trying to reduce the code indentation caused by such IF conditions, making the code more readable.
A rule we try to follow, except when the resulting code is overly complex, is that a method as a single exit point, the end of the method.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8661/#review14647
-----------------------------------------------------------
On Dec. 18, 2012, 2:23 a.m., Ashish Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8661/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 2:23 a.m.)
>
>
> Review request for oozie, Mohammad Islam, Alejandro Abdelnur, Mona Chitnis, Virag Kothari, and Rohini Palaniswamy.
>
>
> Description
> -------
>
> In JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath so that IllegalArgumentException is not thrown in a federated setup.
>
>
> This addresses bug OOZIE-1137.
> https://issues.apache.org/jira/browse/OOZIE-1137
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1423065
>
> Diff: https://reviews.apache.org/r/8661/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Vaidya
>
>
Re: Review Request: [OOZIE-1137] - JavaActionExecutor.java addShareLib()
should use actionLibPath instead of appPath
Posted by Ashish Vaidya <as...@yahoo.com>.
> On Dec. 18, 2012, 2:36 p.m., Alejandro Abdelnur wrote:
> > patch looks good except for the 2 comments on 'condition inversion' changes.
> >
> > 1* Those changes are not related to this patch
> > 2* The current behavior is correct
> > 3* With the current IF logic the method has a single exit point, the end of the method, that is preferable.
> >
I was trying to reduce the code indentation caused by such IF conditions, making the code more readable.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8661/#review14647
-----------------------------------------------------------
On Dec. 18, 2012, 2:23 a.m., Ashish Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8661/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 2:23 a.m.)
>
>
> Review request for oozie, Mohammad Islam, Alejandro Abdelnur, Mona Chitnis, Virag Kothari, and Rohini Palaniswamy.
>
>
> Description
> -------
>
> In JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath so that IllegalArgumentException is not thrown in a federated setup.
>
>
> This addresses bug OOZIE-1137.
> https://issues.apache.org/jira/browse/OOZIE-1137
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1423065
>
> Diff: https://reviews.apache.org/r/8661/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Vaidya
>
>
Re: Review Request: [OOZIE-1137] - JavaActionExecutor.java addShareLib()
should use actionLibPath instead of appPath
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8661/#review14647
-----------------------------------------------------------
patch looks good except for the 2 comments on 'condition inversion' changes.
1* Those changes are not related to this patch
2* The current behavior is correct
3* With the current IF logic the method has a single exit point, the end of the method, that is preferable.
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8661/#comment31080>
why this condition inversion?
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8661/#comment31081>
why this condition inversion?
- Alejandro Abdelnur
On Dec. 18, 2012, 2:23 a.m., Ashish Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8661/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 2:23 a.m.)
>
>
> Review request for oozie, Mohammad Islam, Alejandro Abdelnur, Mona Chitnis, Virag Kothari, and Rohini Palaniswamy.
>
>
> Description
> -------
>
> In JavaActionExecutor.java addShareLib() should use actionLibPath instead of appPath so that IllegalArgumentException is not thrown in a federated setup.
>
>
> This addresses bug OOZIE-1137.
> https://issues.apache.org/jira/browse/OOZIE-1137
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1423065
>
> Diff: https://reviews.apache.org/r/8661/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Vaidya
>
>