You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/11 15:10:50 UTC
[GitHub] [httpcomponents-client] carterkozak opened a new pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
carterkozak opened a new pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241
SSLConnectionSocketFactory no longer overrides the socket timeout
with the connect timeout when an unlimited socket timeout is
configured. This matches behavior of HTTPCLIENT-2091.
Note that in scenarios where SocketConfig sets an infinite timeout
and the RequestConfig sets a bounded timeout, this change results
in the connect-timeout no longer applying to the TLS handshake.
This behavior can be retained by setting the expected timeout in
the SocketConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241#issuecomment-657083102
@carterkozak I apologize for causing such a confusion. I was just being old and stupid. HTTPCLIENT-2091 fix committed to master and not 5.1.x. So, we are all good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241#issuecomment-657082035
@carterkozak No, worries. I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] carterkozak commented on pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241#issuecomment-657080988
oops, my fault, sorry about that. I can set up a revert pr and a second change if you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241#issuecomment-657080184
@carterkozak Damn, the pull request was against master, not the 5.1.x branch. I will have to move it to the 5.1.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] carterkozak commented on pull request #241: HTTPCLIENT-2099: SSLConnectionSocketFactory timeout fix
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #241:
URL: https://github.com/apache/httpcomponents-client/pull/241#issuecomment-657083495
Not a problem, thanks again for your help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org