You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/04/28 09:21:51 UTC
Review Request 58835: Visual explain issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58835/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20883
https://issues.apache.org/jira/browse/AMBARI-20883
Repository: ambari
Description
-------
Used directed arrows rather than simple lines in visual explain and Issue in connection lines for simple queries in visual-explain in Firefox have been fixed.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4
Diff: https://reviews.apache.org/r/58835/diff/1/
Testing
-------
Manual testing have been done
Thanks,
venkat sairam
Re: Review Request 58835: Visual explain issues
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58835/#review173427
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On April 29, 2017, 7:04 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58835/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 7:04 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20883
> https://issues.apache.org/jira/browse/AMBARI-20883
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Used directed arrows rather than simple lines in visual explain and Issue in connection lines for simple queries in visual-explain in Firefox have been fixed.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4
>
>
> Diff: https://reviews.apache.org/r/58835/diff/2/
>
>
> Testing
> -------
>
> Manual testing have been done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58835: Visual explain issues
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58835/#review173437
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 29, 2017, 7:04 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58835/
> -----------------------------------------------------------
>
> (Updated April 29, 2017, 7:04 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20883
> https://issues.apache.org/jira/browse/AMBARI-20883
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Used directed arrows rather than simple lines in visual explain and Issue in connection lines for simple queries in visual-explain in Firefox have been fixed.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4
>
>
> Diff: https://reviews.apache.org/r/58835/diff/2/
>
>
> Testing
> -------
>
> Manual testing have been done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58835: Visual explain issues
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58835/
-----------------------------------------------------------
(Updated April 29, 2017, 7:04 a.m.)
Review request for Ambari, Abhishek Kumar, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Changes
-------
Fixed arrow allignment for huge graphs.
Bugs: AMBARI-20883
https://issues.apache.org/jira/browse/AMBARI-20883
Repository: ambari
Description
-------
Used directed arrows rather than simple lines in visual explain and Issue in connection lines for simple queries in visual-explain in Firefox have been fixed.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4
Diff: https://reviews.apache.org/r/58835/diff/2/
Changes: https://reviews.apache.org/r/58835/diff/1-2/
Testing
-------
Manual testing have been done
Thanks,
venkat sairam