You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "holdenk (via GitHub)" <gi...@apache.org> on 2026/09/25 19:19:32 UTC
[PR] [SPARK-59406][UI][FOLLOW-UP] Fix jquery import in utils.test.js for branch-4.0 [spark]
holdenk opened a new pull request, #59049:
URL: https://github.com/apache/spark/pull/59049
### What changes were proposed in this pull request?
Point the jquery import in `ui-test/tests/utils.test.js` at `jquery-3.5.1.min.js`, the file that actually exists on branch-4.0, matching the other ui-test suites.
### Why are the changes needed?
The SPARK-59406 cherry-pick onto branch-4.0 kept master's import of `jquery.min.js`, which only exists on master after the jquery upgrade there. branch-4.0 still ships `jquery-3.5.1.min.js`, so the suite fails to load:
```
FAIL tests/utils.test.js
● Test suite failed to run
Cannot find module '../../core/src/main/resources/org/apache/spark/ui/static/jquery.min.js' from 'tests/utils.test.js'
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Ran the UI tests the same way CI does (`cd ui-test && npm ci && node --experimental-vm-modules node_modules/.bin/jest`): all 4 suites, 13 tests pass. Previously `utils.test.js` failed to load.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor (Kimi K3)
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59789][UI][FOLLOW-UP][4.0] Fix jquery import in utils.test.js for branch-4.0 [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #59049:
URL: https://github.com/apache/spark/pull/59049#issuecomment-5839260472
UI checks pass and given this broke branch-4.0 UI CI merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59789][UI][FOLLOW-UP][4.0] Fix jquery import in utils.test.js for branch-4.0 [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk closed pull request #59049: [SPARK-59789][UI][FOLLOW-UP][4.0] Fix jquery import in utils.test.js for branch-4.0
URL: https://github.com/apache/spark/pull/59049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org