You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/30 01:02:46 UTC

[GitHub] [arrow-datafusion] yjshen opened a new issue, #2387: Re-organize and rename aggregates physical plan

yjshen opened a new issue, #2387:
URL: https://github.com/apache/arrow-datafusion/issues/2387

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   - We currently have a hash-based implementation, `GroupedHashAggregateStream` for aggregate with grouping keys, and a non-hash implementation for aggregate without grouping keys but named `HashAggregateStream`.
   - We could further enrich the aggregation method from hash-based to sort-based at runtime when we are run out of memory, as described in https://github.com/apache/arrow-datafusion/issues/1570
   
   **Describe the solution you'd like**
   1. Promote `hash_aggregates` to a directory `aggregates`, and re-organize code inside this `aggregates` module.
   2. Rename `HashAggregateExec` to `AggregateExec`, since it's not always hashing.
   
   **Describe alternatives you've considered**
   Don't move
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yjshen closed issue #2387: Re-organize and rename aggregates physical plan

Posted by GitBox <gi...@apache.org>.
yjshen closed issue #2387: Re-organize and rename aggregates physical plan
URL: https://github.com/apache/arrow-datafusion/issues/2387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org