You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/17 20:15:18 UTC

[GitHub] [incubator-superset] willbarrett opened a new pull request #10090: Change logo color to new branding

willbarrett opened a new pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090


   ### SUMMARY
   Updates the color of the Superset logo to match the new branding primary color from Cartel
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   See images in diff
   
   ### TEST PLAN
   View images - are they ok?
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### Reviewers
   @mistercrunch 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas merged pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645622751


   Files look about right... but they're not in use anywhere :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645627680


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=h1) Report
   > Merging [#10090](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/987cb6e1fe932f443020463ac731c0885b535b7f&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10090/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10090      +/-   ##
   ==========================================
   + Coverage   65.80%   65.81%   +0.01%     
   ==========================================
     Files         587      592       +5     
     Lines       31158    31191      +33     
     Branches     3191     3191              
   ==========================================
   + Hits        20503    20529      +26     
   - Misses      10477    10484       +7     
     Partials      178      178              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.74% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `70.11% <ø> (+0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.21% <0.00%> (-1.14%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.82% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.41% <0.00%> (-0.07%)` | :arrow_down: |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [superset/views/redirects.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | `70.00% <0.00%> (ø)` | |
   | [superset/views/health.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvaGVhbHRoLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/views/key\_value.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `87.87% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=footer). Last update [987cb6e...0c7e68c](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645627680


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=h1) Report
   > Merging [#10090](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/987cb6e1fe932f443020463ac731c0885b535b7f&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10090/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10090      +/-   ##
   ==========================================
   + Coverage   65.80%   65.81%   +0.01%     
   ==========================================
     Files         587      592       +5     
     Lines       31158    31191      +33     
     Branches     3191     3191              
   ==========================================
   + Hits        20503    20529      +26     
   - Misses      10477    10484       +7     
     Partials      178      178              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.74% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `70.11% <ø> (+0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.21% <0.00%> (-1.14%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.82% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.41% <0.00%> (-0.07%)` | :arrow_down: |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/views/key\_value.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `87.87% <0.00%> (ø)` | |
   | [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [superset/views/redirects.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | `70.00% <0.00%> (ø)` | |
   | [superset/views/health.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvaGVhbHRoLnB5) | `100.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=footer). Last update [987cb6e...0c7e68c](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645656790


   From here it's easy to alter/copy to `images/` and elsewhere


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645608607


   hmmm....yeah, looks like the dimensions are off a bit. Updating shortly...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645627538


   Yup. This is press kit stuff.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645606680


   @willbarrett some of the png files seem significantly smaller, did they get exported in a scaled down form? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10090: style: Change logo color to new branding

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10090:
URL: https://github.com/apache/incubator-superset/pull/10090#issuecomment-645627680


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=h1) Report
   > Merging [#10090](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/987cb6e1fe932f443020463ac731c0885b535b7f&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10090/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10090      +/-   ##
   ==========================================
   + Coverage   65.80%   65.81%   +0.01%     
   ==========================================
     Files         587      592       +5     
     Lines       31158    31191      +33     
     Branches     3191     3191              
   ==========================================
   + Hits        20503    20529      +26     
   - Misses      10477    10484       +7     
     Partials      178      178              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.74% <ø> (+<0.01%)` | :arrow_up: |
   | #python | `70.11% <ø> (+0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.21% <0.00%> (-1.14%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.82% <0.00%> (-0.14%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.41% <0.00%> (-0.07%)` | :arrow_down: |
   | [superset/views/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [superset/views/key\_value.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | `87.87% <0.00%> (ø)` | |
   | [superset/views/health.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvaGVhbHRoLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/views/redirects.py](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | `70.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/10090/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=footer). Last update [987cb6e...0c7e68c](https://codecov.io/gh/apache/incubator-superset/pull/10090?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org