You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <iv...@visualsvn.com> on 2016/02/15 09:39:48 UTC
Re: svn commit: r1730389 - /subversion/trunk/subversion/libsvn_repos/log.c
On 14 February 2016 at 22:25, <st...@apache.org> wrote:
> Author: stefan2
> Date: Sun Feb 14 19:25:12 2016
> New Revision: 1730389
>
> URL: http://svn.apache.org/viewvc?rev=1730389&view=rev
> Log:
> Begin work on the svn_repos_get_logs4 to svn_repos_get_logs5 migration.
>
> As a first step, we introduce what will become svn_repos_get_logs5 as
> a static function and implement svn_repos_get_logs4 as a wrapper.
The svn_repos__get_logs5() doesn't have docstring, while as far I
understand it has very tricky semantic of delivering data using two
callbacks. Without documented svn_repos__get_logs5() API it's almost
impossible to get idea of all following commits in log.c
--
Ivan Zhakov
Re: svn commit: r1730389 - /subversion/trunk/subversion/libsvn_repos/log.c
Posted by Stefan Fuhrmann <st...@alice-dsl.de>.
On 16.02.2016 11:30, Ivan Zhakov wrote:
> On 16 February 2016 at 08:47, Stefan Fuhrmann <st...@apache.org> wrote:
>> On 15.02.2016 09:39, Ivan Zhakov wrote:
>>>
>>> On 14 February 2016 at 22:25, <st...@apache.org> wrote:
>>>>
>>>> Author: stefan2
>>>> Date: Sun Feb 14 19:25:12 2016
>>>> New Revision: 1730389
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1730389&view=rev
>>>> Log:
>>>> Begin work on the svn_repos_get_logs4 to svn_repos_get_logs5 migration.
>>>>
>>>> As a first step, we introduce what will become svn_repos_get_logs5 as
>>>> a static function and implement svn_repos_get_logs4 as a wrapper.
>>>
>>>
>>> The svn_repos__get_logs5() doesn't have docstring, while as far I
>>> understand it has very tricky semantic of delivering data using two
>>> callbacks. Without documented svn_repos__get_logs5() API it's almost
>>> impossible to get idea of all following commits in log.c
>>
>>
>> The API definition / migration is complete now and the next
>> step is publish it. It'll then get a proper docstring.
>>
> You do this in the wrong way because nobody can meaningfully review
> commits you've already made without this doctring.
>
> Existence of docstring will also help not to develop the program in
> the bottom-up mode. If you don't have all the details at the moment,
> even the preliminary version of docstring will help.
r1731163 describes the callback behaviour. Apart from the
structs being used, the intended behaviour already applies
to the initial changes.
-- Stefan^2.
Re: svn commit: r1730389 - /subversion/trunk/subversion/libsvn_repos/log.c
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 16 February 2016 at 08:47, Stefan Fuhrmann <st...@apache.org> wrote:
> On 15.02.2016 09:39, Ivan Zhakov wrote:
>>
>> On 14 February 2016 at 22:25, <st...@apache.org> wrote:
>>>
>>> Author: stefan2
>>> Date: Sun Feb 14 19:25:12 2016
>>> New Revision: 1730389
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1730389&view=rev
>>> Log:
>>> Begin work on the svn_repos_get_logs4 to svn_repos_get_logs5 migration.
>>>
>>> As a first step, we introduce what will become svn_repos_get_logs5 as
>>> a static function and implement svn_repos_get_logs4 as a wrapper.
>>
>>
>> The svn_repos__get_logs5() doesn't have docstring, while as far I
>> understand it has very tricky semantic of delivering data using two
>> callbacks. Without documented svn_repos__get_logs5() API it's almost
>> impossible to get idea of all following commits in log.c
>
>
> The API definition / migration is complete now and the next
> step is publish it. It'll then get a proper docstring.
>
You do this in the wrong way because nobody can meaningfully review
commits you've already made without this doctring.
Existence of docstring will also help not to develop the program in
the bottom-up mode. If you don't have all the details at the moment,
even the preliminary version of docstring will help.
--
Ivan Zhakov
Re: svn commit: r1730389 - /subversion/trunk/subversion/libsvn_repos/log.c
Posted by Stefan Fuhrmann <st...@apache.org>.
On 15.02.2016 09:39, Ivan Zhakov wrote:
> On 14 February 2016 at 22:25, <st...@apache.org> wrote:
>> Author: stefan2
>> Date: Sun Feb 14 19:25:12 2016
>> New Revision: 1730389
>>
>> URL: http://svn.apache.org/viewvc?rev=1730389&view=rev
>> Log:
>> Begin work on the svn_repos_get_logs4 to svn_repos_get_logs5 migration.
>>
>> As a first step, we introduce what will become svn_repos_get_logs5 as
>> a static function and implement svn_repos_get_logs4 as a wrapper.
>
> The svn_repos__get_logs5() doesn't have docstring, while as far I
> understand it has very tricky semantic of delivering data using two
> callbacks. Without documented svn_repos__get_logs5() API it's almost
> impossible to get idea of all following commits in log.c
The API definition / migration is complete now and the next
step is publish it. It'll then get a proper docstring.
-- Stefan^2.