You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by BruceKuiLiu <gi...@git.apache.org> on 2017/10/14 16:05:09 UTC
[GitHub] ant pull request #47: Add the "final" modifier to a public static field.
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/47
Add the "final" modifier to a public static field.
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.
http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/ant master4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit ab72f9071269121d5b9fd7e38130a3ae4a8ed1a9
Author: Kui LIU <br...@gmail.com>
Date: 2017-10-14T14:45:32Z
Add the "final" modifier to a public static field.
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.
http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #47: Add the "final" modifier to a public static field.
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/47
Similar to #44 we cannot change a public API and thus will not merge this request.
In this particular case we even once changed it and had to revert the field to be non-final as we broike the Eclipse integration https://github.com/apache/ant/commit/984a03d1ceb6e4b5d194e4d639d0b0fca46d92be
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #47: Add the "final" modifier to a public static field.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/47
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org