You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2017/05/12 18:29:35 UTC
Review Request 59237: GEODE-2875 shutdown is taking as long as 20
seconds
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59237/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: GEODE-2875
https://issues.apache.org/jira/browse/GEODE-2875
Repository: geode
Description
-------
The fix for this issue causes one of the test cases in LocatorDUnitTest to fail consistently. With the fix we don't create any TCP/IP connections in this test during startup but the test expects one to have been created and it expects the connection's reader-thread to have initiated suspect processing.
The test needs to be altered to ensure that this thread has been created by sending message that requires a reply. The reply will be sent over the expected connection, ensuring that there is a reader-thread.
Diffs
-----
geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 6f01f9094bb9cfb35031c51472b2fd9a532e3ee3
Diff: https://reviews.apache.org/r/59237/diff/1/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 59237: GEODE-2875 shutdown is taking as long as 20
seconds
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59237/#review174848
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On May 12, 2017, 6:29 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59237/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 6:29 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2875
> https://issues.apache.org/jira/browse/GEODE-2875
>
>
> Repository: geode
>
>
> Description
> -------
>
> The fix for this issue causes one of the test cases in LocatorDUnitTest to fail consistently. With the fix we don't create any TCP/IP connections in this test during startup but the test expects one to have been created and it expects the connection's reader-thread to have initiated suspect processing.
>
> The test needs to be altered to ensure that this thread has been created by sending message that requires a reply. The reply will be sent over the expected connection, ensuring that there is a reader-thread.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 6f01f9094bb9cfb35031c51472b2fd9a532e3ee3
>
>
> Diff: https://reviews.apache.org/r/59237/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 59237: GEODE-2875 shutdown is taking as long as 20
seconds
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59237/#review174831
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On May 12, 2017, 6:29 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59237/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 6:29 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2875
> https://issues.apache.org/jira/browse/GEODE-2875
>
>
> Repository: geode
>
>
> Description
> -------
>
> The fix for this issue causes one of the test cases in LocatorDUnitTest to fail consistently. With the fix we don't create any TCP/IP connections in this test during startup but the test expects one to have been created and it expects the connection's reader-thread to have initiated suspect processing.
>
> The test needs to be altered to ensure that this thread has been created by sending message that requires a reply. The reply will be sent over the expected connection, ensuring that there is a reader-thread.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 6f01f9094bb9cfb35031c51472b2fd9a532e3ee3
>
>
> Diff: https://reviews.apache.org/r/59237/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>