[GitHub] [ignite-3] korlov42 commented on a diff in pull request #712: IGNITE-16401 Working in async manner for new SQL engine

[GitBox <gi...@apache.org>]

korlov42 commented on code in PR #712:
URL: https://github.com/apache/ignite-3/pull/712#discussion_r864728073


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/AsyncCursor.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine;
+
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
+
+/**
+ * Asynchronous cursor.
+ *
+ * @param <T> Type of elements.
+ */
+public interface AsyncCursor<T> {
+    /**
+     * Request next batch of rows.
+     *
+     * <p>Several calls to this method should be chained and resulting stages should be completed in the order of invocation. Any call
+     * to this method after call to {@link #close()} should be completed immediately with
+     * {@link org.apache.ignite.internal.sql.engine.ClosedCursorException} even if the future returned by {@link #close()}
+     * is not completed yet.
+     *
+     * @param rows Desired amount of rows.
+     * @return A completion stage that will be completed with batch of size {@code rows} or less if there is no more data.
+     */
+    CompletionStage<BatchedResult<T>> requestNext(int rows);

Review Comment:
   You're right, but this is a part of internal API 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org