[GitHub] [spark] yaooqinn commented on a change in pull request #26410: [SPARK-29387][SQL][FOLLOWUP] Fix issues of the multiply and divide for intervals

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #26410: [SPARK-29387][SQL][FOLLOWUP] Fix issues of the multiply and divide for intervals
URL: https://github.com/apache/spark/pull/26410#discussion_r342997830
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
 ##########
 @@ -137,7 +137,11 @@ abstract class IntervalNumOperation(
       val iu = IntervalUtils.getClass.getName.stripSuffix("$")
       s"""
         try {
-          ${ev.value} = $iu.$operationName($interval, $num);
+          if ($num != 0) {
 
 Review comment:
   The literals will do `eval` not `codegen`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org