[GitHub] [lucene] rmuir commented on pull request #12135: Avoid duplicate sorting and prefix-encoding in KeywordField#newSetQuery

["rmuir (via GitHub)" <gi...@apache.org>]

rmuir commented on PR #12135:
URL: https://github.com/apache/lucene/pull/12135#issuecomment-1422891907

   I'm not sure how i feel about exposing PrefixCodedTerms in public apis. This really seems like an over-optimization and causes clutter. Maybe we can get @uschindler thoughts and consider using streams internally and avoid messing with PrefixCodedTerms, i think its possible to implement the `KeywordField#newSetQuery` so that stream is only sorted once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org