[GitHub] [doris] github-actions[bot] commented on pull request #20776: [feature-wip](hplsql) Integrate hplsql into doris to support stored procedure

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #20776:
URL: https://github.com/apache/doris/pull/20776#issuecomment-1590373958

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5262565012") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In bin/hplsql.sh line 44:
       JAVA="$(which java)"
               ^---^ SC2230 (info): 'which' is non-standard. Use builtin 'command -v' instead.
   
   
   In bin/hplsql.sh line 82:
   java_version="$(
   ^----------^ SC2034 (warning): java_version appears unused. Verify use (or export if used externally).
   
   For more information:
     https://www.shellcheck.net/wiki/SC2034 -- java_version appears unused. Veri...
     https://www.shellcheck.net/wiki/SC2230 -- 'which' is non-standard. Use buil...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- bin/hplsql.sh.orig
   +++ bin/hplsql.sh
   @@ -107,4 +107,3 @@
    fi
    
    ${LIMIT:+${LIMIT}} "${JAVA}" ${final_java_opt:+${final_java_opt}} -XX:-OmitStackTraceInFastThrow -XX:OnOutOfMemoryError="kill -9 %p" org.apache.doris.hplsql.Hplsql ${HELPER:+${HELPER}} ${OPT_VERSION:+${OPT_VERSION}} "$@" </dev/null
   -
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org