[GitHub] [incubator-uniffle] zjf2012 commented on a diff in pull request #495: [ISSUE-476][FEATURE] Respect "spark.shuffle.compress" configuration in Uniffle

[GitBox <gi...@apache.org>]

zjf2012 commented on code in PR #495:
URL: https://github.com/apache/incubator-uniffle/pull/495#discussion_r1071967668


##########
client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java:
##########
@@ -66,7 +67,8 @@ public RssShuffleDataIterator(
     this.serializerInstance = serializer.newInstance();
     this.shuffleReadClient = shuffleReadClient;
     this.shuffleReadMetrics = shuffleReadMetrics;
-    this.codec = Codec.newInstance(rssConf);
+    boolean compress = rssConf.getBoolean(RssClientConfig.SPARK_SHUFFLE_COMPRESS, true);

Review Comment:
   no, I tried to use "spark.shuffle.compress". But rssConf removes "spark." prefix. And in spark2 module, the referenced spark version is too old which doesn't have below definition in spark's config object. So, I have to declare it in RssClientConfig.
   
     private[spark] val SHUFFLE_COMPRESS =
       ConfigBuilder("spark.shuffle.compress")
         .doc("Whether to compress shuffle output. Compression will use " +
           "spark.io.compression.codec.")
         .version("0.6.0")
         .booleanConf
         .createWithDefault(true)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org