You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/11 03:43:43 UTC
[GitHub] [incubator-apisix] ywengineer opened a new pull request #1569: enable request stats when run with tengine
ywengineer opened a new pull request #1569:
URL: https://github.com/apache/incubator-apisix/pull/1569
### Summary
enable request stats when run with tengine
### Full changelog
* enable request stats when run with tengine
* customize allow ip addresses when access /apisix/nginx_status and /apisix/stats-rss. default is 127.0.0.0/24
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1569: enable request stats when run with tengine
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1569:
URL: https://github.com/apache/incubator-apisix/pull/1569#issuecomment-626614756
one PR should only do one thing. you can submit a new PR for `enable request stats when run with tengine`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1569: enable request stats when run with tengine
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1569:
URL: https://github.com/apache/incubator-apisix/pull/1569#discussion_r422887635
##########
File path: bin/apisix
##########
@@ -38,8 +38,8 @@ local pkg_path_org = package.path
local apisix_home = "/usr/local/apisix"
local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;"
- .. apisix_home .. "/deps/lib/lua/5.1/?.so;;"
-local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;"
+ .. apisix_home .. "/deps/lib/lua/5.1/?.so;;"
Review comment:
Please do not make changes that are not related to this PR, it will make the review difficult
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis edited a comment on pull request #1569: enable request stats when run with tengine
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on pull request #1569:
URL: https://github.com/apache/incubator-apisix/pull/1569#issuecomment-626614756
one PR should only do one thing. you can submit a new PR for `enable request stats when run with tengine`
so I closed this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org