You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/14 00:20:10 UTC

[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #12009: fix: Scroll for big charts

mistercrunch edited a comment on pull request #12009:
URL: https://github.com/apache/incubator-superset/pull/12009#issuecomment-744095564


   This used to work, unclear what created the regression here, but could be related to the recent work with the data south pane.
   
   I haven't pull the branch here, but I think it's likely that this may bring in regressions around showing scrollbars where they should not be shown (that scroll by a few pixels).
   
   I think typically the scrolling (if needed) should be declared in the visualization plugin itself. The plugin receives information about height/width, and a pointer to the dom element, and it can do whatever it wants with it, and manage its own scrolling in a way that makes sense for that particular visualization (table has vertical with fixed headers, bar overflows horizontal only, ...). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org