You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/05/11 07:46:21 UTC

Re: Review Request 66847: Added per framework metric for offer operation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66847/
-----------------------------------------------------------

(Updated May 11, 2018, 12:46 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.


Summary (updated)
-----------------

Added per framework metric for offer operation.


Repository: mesos


Description (updated)
-------

Added per framework metric for offer operation.


Diffs (updated)
-----

  src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66847/diff/3/

Changes: https://reviews.apache.org/r/66847/diff/2-3/


Testing
-------


Thanks,

Gilbert Song


Re: Review Request 66847: Added per framework metric for offer operation.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66847/
-----------------------------------------------------------

(Updated May 15, 2018, 5:46 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.


Bugs: MESOS-8845
    https://issues.apache.org/jira/browse/MESOS-8845


Repository: mesos


Description
-------

Added per framework metric for offer operation.


Diffs (updated)
-----

  src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66847/diff/5/

Changes: https://reviews.apache.org/r/66847/diff/4-5/


Testing
-------


Thanks,

Gilbert Song


Re: Review Request 66847: Added per framework metric for offer operation.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66847/#review203175
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On May 11, 2018, 8:44 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66847/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 8:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per framework metric for offer operation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/66847/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 66847: Added per framework metric for offer operation.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66847/
-----------------------------------------------------------

(Updated May 11, 2018, 1:44 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

Added per framework metric for offer operation.


Diffs (updated)
-----

  src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66847/diff/4/

Changes: https://reviews.apache.org/r/66847/diff/3-4/


Testing
-------


Thanks,

Gilbert Song