You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@baremaps.apache.org by Bertil Chapuis <bc...@gmail.com> on 2022/10/18 20:44:22 UTC

Code style and root package

Hello Everyone,

I think we received all the ICLAs and we will soon be able to leave the baremaps github organisation for a new home.

In preparation for the changes ahead, I renamed the root package into org.apache.baremaps and updated the code style. These changes affect most source code and configuration files in the repository. I tried the snapshot release locally and everything works well.

https://github.com/baremaps/baremaps/pull/496

If you dream of a large cosmetic change in the codebase, now is the time to discuss it ;) We have a short window of time with few branches and pull requests open.

Best regards,

Bertil



Re: Code style and root package

Posted by Julian Hyde <jh...@gmail.com>.
Regarding the GPL/LGPL dependencies. It is true that an ASF top-level project cannot make releases with those dependencies. But these issues can be solved during incubation. Incubating projects have some leeway while making their first releases. I suggest that you do not try to solve the GPL/LGPL problems now.

Regarding copyright. If you changed a copyright notice from ‘Copyright 2020’ to ‘Copyright 2022’ that is a misrepresentation, because you are claiming that all of the code in that file was written in 2022 and therefore (assuming a hypothetical 50 years of copyright protection) would be protected by copyright until 2072. When in fact some of the code would expire in 2070. Long story short, you should add years to the copyright notice, not modify/remove them. But dealing with copyright notices is another thing that is best done during incubation.

Apache policy is to move copyright notices into NOTICE files. Again, best done during incubation.

> On Oct 21, 2022, at 1:19 AM, Bertil Chapuis <bc...@gmail.com> wrote:
> 
> 
>>> Changing package names is probably harmless. But file headers and
>>> copyright notices should not be changed until after IP transfer
>>> (repository migration).
> 
> The license header was changed before this discussion (19 days ago). The LICENSE.header file contained an outdated copyright notice (2020) that I simply removed. I can rollback these changes if needed, but as the LICENSE file was present from the beginning of the projet, can we assume that everyone agreed with these terms?
> 
> Along this line, the steps needed to address licensing issues and IP clearance during incubation remain a bit vague to me and I created an issue to track them.
> https://github.com/baremaps/baremaps/issues/502
> 
> In terms of license, all the LGPL dependencies have been replaced last summer. My main concern is related to the osmpbf data format. The protobuf descriptor used by this format is released under the terms of the GNU Lesser General Public License. In my understanding this file should not be included in our release, however, we can include the source files we generate with it. Is this interpretation correct?
> https://github.com/baremaps/baremaps/blob/main/baremaps-osm/src/main/proto/osmformat.proto
> 
> 
>>> I'm not 100% sure, but I don't think that GitHub PRs and issues will
>>> come through the IP transfer process. If so, people may need to open
>>> new PRs once the repo is in Apache.
>> don't worry, the Issue PR will all move over, just the upstream and
>> downstream relationship changes a little bit, but that doesn't matter
>> at all.
> 
> Good to know, thank you.
> 
>>> 
>>> Are there any reasons why we can't start the repository migration?
>> I see the secretary has confirmed everyone's ICLA. I think we can
>> start moving now.
>> https://issues.apache.org/jira/browse/INFRA-23762
> 
> I think we can start the migration and I notified Drew Foulks two days ago. I tried to invite him in the github organization, but I havn’t found his username on github.
> 
> Best,
> 
> Bertil
> 
> 
> 
>>> 
>>> The status page, https://incubator.apache.org/projects/baremaps.html,
>>> is probably a good guide to these tasks.
>>> 
>>> On Wed, Oct 19, 2022 at 8:58 AM Antoine Drabble
>>> <an...@gmail.com> wrote:
>>>> 
>>>> Hi Bertil,
>>>> 
>>>> This is great news for the ICLAs!
>>>> 
>>>> I have made a review of your PR regarding the package name and the code
>>>> style. I hope we can merge it as soon as possible to avoid conflicts.
>>>> 
>>>> Otherwise I'm looking forward to our meeting on the 25th.
>>>> 
>>>> Have a good day,
>>>> Antoine Drabble
>>>> 
>>>> On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:
>>>> 
>>>>> Hello Everyone,
>>>>> 
>>>>> I think we received all the ICLAs and we will soon be able to leave the
>>>>> baremaps github organisation for a new home.
>>>>> 
>>>>> In preparation for the changes ahead, I renamed the root package into
>>>>> org.apache.baremaps and updated the code style. These changes affect most
>>>>> source code and configuration files in the repository. I tried the snapshot
>>>>> release locally and everything works well.
>>>>> 
>>>>> https://github.com/baremaps/baremaps/pull/496
>>>>> 
>>>>> If you dream of a large cosmetic change in the codebase, now is the time
>>>>> to discuss it ;) We have a short window of time with few branches and pull
>>>>> requests open.
>>>>> 
>>>>> Best regards,
>>>>> 
>>>>> Bertil
>>>>> 
>>>>> 
>>>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
>>> For additional commands, e-mail: dev-help@baremaps.apache.org
>>> 
>> 
>> 
>> --
>> Best wishes!
>> CalvinKirs
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
>> For additional commands, e-mail: dev-help@baremaps.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
For additional commands, e-mail: dev-help@baremaps.apache.org


Re: Code style and root package

Posted by Bertil Chapuis <bc...@gmail.com>.
After spending some time

> On 21 Oct 2022, at 16:37, Martin Desruisseaux <ma...@geomatys.com> wrote:
> 
> Le 21/10/2022 à 13:19, Bertil Chapuis a écrit :
>> (…snip…) You are right, apparently the output of a generator inherits the license of the template. (…snip…) George and Martin, do you have experience with this kind of issues and on how to address it?
> In my understanding of [1], the GPL-derived work needs to be an optional feature. The Baremaps version downloaded from Apache servers shall not include GPL-copyrighted feature and should be able to work without it. However it is okay to offer this feature as an optional download after Baremaps installation.
> 
> Apache NetBeans had a similar process for "nb-javac". When launching NetBeans for the first time, a popup dialog appeared and offered to download nb-javac with a clear notice that it is under GPL license. If the user refuses, NetBeans still work with only some functionality degraded. Apache SIS does something similar with EPSG geodetic database: when starting the JavaFX application, a dialog box appears offering user to download EPSG dataset with a clear notice that they are under EPSG terms of use. If the user refuses, Apache SIS will still work but CRS will have to be defined by other means than EPSG codes (e.g. using WKT instead).
> 
> In the case of Baremaps, if the GPL-derived work is just one format among others and if there is good free alternatives, what about not even bothering user with a dialog box and just document in the web site that support for this format is an extension available as a separated download? The source code could not be included in Apache releases however; it would have to be somewhere else. Maybe a "Baremaps extension" project on GitHib?
> 
>     Martin
> 
> [1] https://www.apache.org/legal/resolved.html#optional

Thanks a lot for these clarifications. It is good to know that letting users download non-free dependencies separately is possible.

After digging for a while, I found the following ticket in the OSM-binary repository. Apparently, this was a known issue and the file has been relicensed (MIT) by its authors in 2019. I will use this version instead and logged and issue to address this change.

[1] https://github.com/openstreetmap/OSM-binary/pull/35
[2] https://github.com/baremaps/baremaps/issues/503

Re: Code style and root package

Posted by Martin Desruisseaux <ma...@geomatys.com>.
Le 21/10/2022 à 13:19, Bertil Chapuis a écrit :
> (…snip…) You are right, apparently the output of a generator inherits 
> the license of the template. (…snip…) George and Martin, do you have 
> experience with this kind of issues and on how to address it?

In my understanding of [1], the GPL-derived work needs to be an optional 
feature. The Baremaps version downloaded from Apache servers shall not 
include GPL-copyrighted feature and should be able to work without it. 
However it is okay to offer this feature as an optional download after 
Baremaps installation.

Apache NetBeans had a similar process for "nb-javac". When launching 
NetBeans for the first time, a popup dialog appeared and offered to 
download nb-javac with a clear notice that it is under GPL license. If 
the user refuses, NetBeans still work with only some functionality 
degraded. Apache SIS does something similar with EPSG geodetic database: 
when starting the JavaFX application, a dialog box appears offering user 
to download EPSG dataset with a clear notice that they are under EPSG 
terms of use. If the user refuses, Apache SIS will still work but CRS 
will have to be defined by other means than EPSG codes (e.g. using WKT 
instead).

In the case of Baremaps, if the GPL-derived work is just one format 
among others and if there is good free alternatives, what about not even 
bothering user with a dialog box and just document in the web site that 
support for this format is an extension available as a separated 
download? The source code could not be included in Apache releases 
however; it would have to be somewhere else. Maybe a "Baremaps 
extension" project on GitHib?

     Martin

[1]https://www.apache.org/legal/resolved.html#optional

Re: Code style and root package

Posted by Bertil Chapuis <bc...@gmail.com>.
>> In terms of license, all the LGPL dependencies have been replaced last summer. My main concern is related to the osmpbf data format. The protobuf descriptor used by this format is released under the terms of the GNU Lesser General Public License. In my understanding this file should not be included in our release, however, we can include the source files we generate with it. Is this interpretation correct?
>> https://github.com/baremaps/baremaps/blob/main/baremaps-osm/src/main/proto/osmformat.proto
> This is not allowed. even though you use an automatically generated
> file, essentially its license does not change.

Sorry, I focused on the dependency tree and this file went under my radar until I checked everything again this week. You are right, apparently the output of a generator inherits the license of the template.
https://opensource.stackexchange.com/questions/9780/license-of-code-generated-by-a-code-generator

George and Martin, do you have experience with this kind of issues and on how to address it? I guess this question is common to a lot of the geospatial projects at Apache. Maybe we could ask the author of the format if he would be ready to release the template with a more permissive license.

>>>> I'm not 100% sure, but I don't think that GitHub PRs and issues will
>>>> come through the IP transfer process. If so, people may need to open
>>>> new PRs once the repo is in Apache.
>>> don't worry, the Issue PR will all move over, just the upstream and
>>> downstream relationship changes a little bit, but that doesn't matter
>>> at all.
>> 
>> Good to know, thank you.
>> 
>>>> 
>>>> Are there any reasons why we can't start the repository migration?
>>> I see the secretary has confirmed everyone's ICLA. I think we can
>>> start moving now.
>>> https://issues.apache.org/jira/browse/INFRA-23762
>> 
>> I think we can start the migration and I notified Drew Foulks two days ago. I tried to invite him in the github organization, but I havn’t found his username on github.
>> 
>> Best,
>> 
>> Bertil
>> 
>> 
>> 
>>>> 
>>>> The status page, https://incubator.apache.org/projects/baremaps.html,
>>>> is probably a good guide to these tasks.
>>>> 
>>>> On Wed, Oct 19, 2022 at 8:58 AM Antoine Drabble
>>>> <an...@gmail.com> wrote:
>>>>> 
>>>>> Hi Bertil,
>>>>> 
>>>>> This is great news for the ICLAs!
>>>>> 
>>>>> I have made a review of your PR regarding the package name and the code
>>>>> style. I hope we can merge it as soon as possible to avoid conflicts.
>>>>> 
>>>>> Otherwise I'm looking forward to our meeting on the 25th.
>>>>> 
>>>>> Have a good day,
>>>>> Antoine Drabble
>>>>> 
>>>>> On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:
>>>>> 
>>>>>> Hello Everyone,
>>>>>> 
>>>>>> I think we received all the ICLAs and we will soon be able to leave the
>>>>>> baremaps github organisation for a new home.
>>>>>> 
>>>>>> In preparation for the changes ahead, I renamed the root package into
>>>>>> org.apache.baremaps and updated the code style. These changes affect most
>>>>>> source code and configuration files in the repository. I tried the snapshot
>>>>>> release locally and everything works well.
>>>>>> 
>>>>>> https://github.com/baremaps/baremaps/pull/496
>>>>>> 
>>>>>> If you dream of a large cosmetic change in the codebase, now is the time
>>>>>> to discuss it ;) We have a short window of time with few branches and pull
>>>>>> requests open.
>>>>>> 
>>>>>> Best regards,
>>>>>> 
>>>>>> Bertil
>>>>>> 
>>>>>> 
>>>>>> 
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
>>>> For additional commands, e-mail: dev-help@baremaps.apache.org
>>>> 
>>> 
>>> 
>>> --
>>> Best wishes!
>>> CalvinKirs
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
>>> For additional commands, e-mail: dev-help@baremaps.apache.org
>> 
> 
> 
> --
> Best wishes!
> CalvinKirs
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
> For additional commands, e-mail: dev-help@baremaps.apache.org


Re: Code style and root package

Posted by Calvin Kirs <ki...@apache.org>.
On Fri, Oct 21, 2022 at 3:19 AM Bertil Chapuis <bc...@gmail.com> wrote:
>
>
> >> Changing package names is probably harmless. But file headers and
> >> copyright notices should not be changed until after IP transfer
> >> (repository migration).
>
> The license header was changed before this discussion (19 days ago). The LICENSE.header file contained an outdated copyright notice (2020) that I simply removed. I can rollback these changes if needed, but as the LICENSE file was present from the beginning of the projet, can we assume that everyone agreed with these terms?
>
> Along this line, the steps needed to address licensing issues and IP clearance during incubation remain a bit vague to me and I created an issue to track them.
> https://github.com/baremaps/baremaps/issues/502
>
> In terms of license, all the LGPL dependencies have been replaced last summer. My main concern is related to the osmpbf data format. The protobuf descriptor used by this format is released under the terms of the GNU Lesser General Public License. In my understanding this file should not be included in our release, however, we can include the source files we generate with it. Is this interpretation correct?
> https://github.com/baremaps/baremaps/blob/main/baremaps-osm/src/main/proto/osmformat.proto
This is not allowed. even though you use an automatically generated
file, essentially its license does not change.
>
>
> >> I'm not 100% sure, but I don't think that GitHub PRs and issues will
> >> come through the IP transfer process. If so, people may need to open
> >> new PRs once the repo is in Apache.
> > don't worry, the Issue PR will all move over, just the upstream and
> > downstream relationship changes a little bit, but that doesn't matter
> > at all.
>
> Good to know, thank you.
>
> >>
> >> Are there any reasons why we can't start the repository migration?
> > I see the secretary has confirmed everyone's ICLA. I think we can
> > start moving now.
> > https://issues.apache.org/jira/browse/INFRA-23762
>
> I think we can start the migration and I notified Drew Foulks two days ago. I tried to invite him in the github organization, but I havn’t found his username on github.
>
> Best,
>
> Bertil
>
>
>
> >>
> >> The status page, https://incubator.apache.org/projects/baremaps.html,
> >> is probably a good guide to these tasks.
> >>
> >> On Wed, Oct 19, 2022 at 8:58 AM Antoine Drabble
> >> <an...@gmail.com> wrote:
> >>>
> >>> Hi Bertil,
> >>>
> >>> This is great news for the ICLAs!
> >>>
> >>> I have made a review of your PR regarding the package name and the code
> >>> style. I hope we can merge it as soon as possible to avoid conflicts.
> >>>
> >>> Otherwise I'm looking forward to our meeting on the 25th.
> >>>
> >>> Have a good day,
> >>> Antoine Drabble
> >>>
> >>> On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:
> >>>
> >>>> Hello Everyone,
> >>>>
> >>>> I think we received all the ICLAs and we will soon be able to leave the
> >>>> baremaps github organisation for a new home.
> >>>>
> >>>> In preparation for the changes ahead, I renamed the root package into
> >>>> org.apache.baremaps and updated the code style. These changes affect most
> >>>> source code and configuration files in the repository. I tried the snapshot
> >>>> release locally and everything works well.
> >>>>
> >>>> https://github.com/baremaps/baremaps/pull/496
> >>>>
> >>>> If you dream of a large cosmetic change in the codebase, now is the time
> >>>> to discuss it ;) We have a short window of time with few branches and pull
> >>>> requests open.
> >>>>
> >>>> Best regards,
> >>>>
> >>>> Bertil
> >>>>
> >>>>
> >>>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
> >> For additional commands, e-mail: dev-help@baremaps.apache.org
> >>
> >
> >
> > --
> > Best wishes!
> > CalvinKirs
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
> > For additional commands, e-mail: dev-help@baremaps.apache.org
>


-- 
Best wishes!
CalvinKirs

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
For additional commands, e-mail: dev-help@baremaps.apache.org


Re: Code style and root package

Posted by Bertil Chapuis <bc...@gmail.com>.
>> Changing package names is probably harmless. But file headers and
>> copyright notices should not be changed until after IP transfer
>> (repository migration).

The license header was changed before this discussion (19 days ago). The LICENSE.header file contained an outdated copyright notice (2020) that I simply removed. I can rollback these changes if needed, but as the LICENSE file was present from the beginning of the projet, can we assume that everyone agreed with these terms?

Along this line, the steps needed to address licensing issues and IP clearance during incubation remain a bit vague to me and I created an issue to track them.
https://github.com/baremaps/baremaps/issues/502

In terms of license, all the LGPL dependencies have been replaced last summer. My main concern is related to the osmpbf data format. The protobuf descriptor used by this format is released under the terms of the GNU Lesser General Public License. In my understanding this file should not be included in our release, however, we can include the source files we generate with it. Is this interpretation correct?
https://github.com/baremaps/baremaps/blob/main/baremaps-osm/src/main/proto/osmformat.proto


>> I'm not 100% sure, but I don't think that GitHub PRs and issues will
>> come through the IP transfer process. If so, people may need to open
>> new PRs once the repo is in Apache.
> don't worry, the Issue PR will all move over, just the upstream and
> downstream relationship changes a little bit, but that doesn't matter
> at all.

Good to know, thank you.

>> 
>> Are there any reasons why we can't start the repository migration?
> I see the secretary has confirmed everyone's ICLA. I think we can
> start moving now.
> https://issues.apache.org/jira/browse/INFRA-23762

I think we can start the migration and I notified Drew Foulks two days ago. I tried to invite him in the github organization, but I havn’t found his username on github.

Best,

Bertil



>> 
>> The status page, https://incubator.apache.org/projects/baremaps.html,
>> is probably a good guide to these tasks.
>> 
>> On Wed, Oct 19, 2022 at 8:58 AM Antoine Drabble
>> <an...@gmail.com> wrote:
>>> 
>>> Hi Bertil,
>>> 
>>> This is great news for the ICLAs!
>>> 
>>> I have made a review of your PR regarding the package name and the code
>>> style. I hope we can merge it as soon as possible to avoid conflicts.
>>> 
>>> Otherwise I'm looking forward to our meeting on the 25th.
>>> 
>>> Have a good day,
>>> Antoine Drabble
>>> 
>>> On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:
>>> 
>>>> Hello Everyone,
>>>> 
>>>> I think we received all the ICLAs and we will soon be able to leave the
>>>> baremaps github organisation for a new home.
>>>> 
>>>> In preparation for the changes ahead, I renamed the root package into
>>>> org.apache.baremaps and updated the code style. These changes affect most
>>>> source code and configuration files in the repository. I tried the snapshot
>>>> release locally and everything works well.
>>>> 
>>>> https://github.com/baremaps/baremaps/pull/496
>>>> 
>>>> If you dream of a large cosmetic change in the codebase, now is the time
>>>> to discuss it ;) We have a short window of time with few branches and pull
>>>> requests open.
>>>> 
>>>> Best regards,
>>>> 
>>>> Bertil
>>>> 
>>>> 
>>>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
>> For additional commands, e-mail: dev-help@baremaps.apache.org
>> 
> 
> 
> --
> Best wishes!
> CalvinKirs
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
> For additional commands, e-mail: dev-help@baremaps.apache.org


Re: Code style and root package

Posted by Calvin Kirs <ki...@apache.org>.
On Wed, Oct 19, 2022 at 2:44 PM Julian Hyde <jh...@apache.org> wrote:
>
> Changing package names is probably harmless. But file headers and
> copyright notices should not be changed until after IP transfer
> (repository migration).
>
> I'm not 100% sure, but I don't think that GitHub PRs and issues will
> come through the IP transfer process. If so, people may need to open
> new PRs once the repo is in Apache.
don't worry, the Issue PR will all move over, just the upstream and
downstream relationship changes a little bit, but that doesn't matter
at all.
>
> Are there any reasons why we can't start the repository migration?
I see the secretary has confirmed everyone's ICLA. I think we can
start moving now.
https://issues.apache.org/jira/browse/INFRA-23762
>
> The status page, https://incubator.apache.org/projects/baremaps.html,
> is probably a good guide to these tasks.
>
> On Wed, Oct 19, 2022 at 8:58 AM Antoine Drabble
> <an...@gmail.com> wrote:
> >
> > Hi Bertil,
> >
> > This is great news for the ICLAs!
> >
> > I have made a review of your PR regarding the package name and the code
> > style. I hope we can merge it as soon as possible to avoid conflicts.
> >
> > Otherwise I'm looking forward to our meeting on the 25th.
> >
> > Have a good day,
> > Antoine Drabble
> >
> > On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:
> >
> > > Hello Everyone,
> > >
> > > I think we received all the ICLAs and we will soon be able to leave the
> > > baremaps github organisation for a new home.
> > >
> > > In preparation for the changes ahead, I renamed the root package into
> > > org.apache.baremaps and updated the code style. These changes affect most
> > > source code and configuration files in the repository. I tried the snapshot
> > > release locally and everything works well.
> > >
> > > https://github.com/baremaps/baremaps/pull/496
> > >
> > > If you dream of a large cosmetic change in the codebase, now is the time
> > > to discuss it ;) We have a short window of time with few branches and pull
> > > requests open.
> > >
> > > Best regards,
> > >
> > > Bertil
> > >
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
> For additional commands, e-mail: dev-help@baremaps.apache.org
>


-- 
Best wishes!
CalvinKirs

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
For additional commands, e-mail: dev-help@baremaps.apache.org


Re: Code style and root package

Posted by Julian Hyde <jh...@apache.org>.
Changing package names is probably harmless. But file headers and
copyright notices should not be changed until after IP transfer
(repository migration).

I'm not 100% sure, but I don't think that GitHub PRs and issues will
come through the IP transfer process. If so, people may need to open
new PRs once the repo is in Apache.

Are there any reasons why we can't start the repository migration?

The status page, https://incubator.apache.org/projects/baremaps.html,
is probably a good guide to these tasks.

On Wed, Oct 19, 2022 at 8:58 AM Antoine Drabble
<an...@gmail.com> wrote:
>
> Hi Bertil,
>
> This is great news for the ICLAs!
>
> I have made a review of your PR regarding the package name and the code
> style. I hope we can merge it as soon as possible to avoid conflicts.
>
> Otherwise I'm looking forward to our meeting on the 25th.
>
> Have a good day,
> Antoine Drabble
>
> On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:
>
> > Hello Everyone,
> >
> > I think we received all the ICLAs and we will soon be able to leave the
> > baremaps github organisation for a new home.
> >
> > In preparation for the changes ahead, I renamed the root package into
> > org.apache.baremaps and updated the code style. These changes affect most
> > source code and configuration files in the repository. I tried the snapshot
> > release locally and everything works well.
> >
> > https://github.com/baremaps/baremaps/pull/496
> >
> > If you dream of a large cosmetic change in the codebase, now is the time
> > to discuss it ;) We have a short window of time with few branches and pull
> > requests open.
> >
> > Best regards,
> >
> > Bertil
> >
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@baremaps.apache.org
For additional commands, e-mail: dev-help@baremaps.apache.org


Re: Code style and root package

Posted by Antoine Drabble <an...@gmail.com>.
Hi Bertil,

This is great news for the ICLAs!

I have made a review of your PR regarding the package name and the code
style. I hope we can merge it as soon as possible to avoid conflicts.

Otherwise I'm looking forward to our meeting on the 25th.

Have a good day,
Antoine Drabble

On Tue, 18 Oct 2022 at 22:45, Bertil Chapuis <bc...@gmail.com> wrote:

> Hello Everyone,
>
> I think we received all the ICLAs and we will soon be able to leave the
> baremaps github organisation for a new home.
>
> In preparation for the changes ahead, I renamed the root package into
> org.apache.baremaps and updated the code style. These changes affect most
> source code and configuration files in the repository. I tried the snapshot
> release locally and everything works well.
>
> https://github.com/baremaps/baremaps/pull/496
>
> If you dream of a large cosmetic change in the codebase, now is the time
> to discuss it ;) We have a short window of time with few branches and pull
> requests open.
>
> Best regards,
>
> Bertil
>
>
>

Re: Code style and root package

Posted by Josh Fischer <jo...@joshfischer.io>.
I dream of no cosmetic changes at the moment. I plan to take some time this
weekend to get into the code base a little more.

On Tue, Oct 18, 2022 at 3:45 PM Bertil Chapuis <bc...@gmail.com> wrote:

> Hello Everyone,
>
> I think we received all the ICLAs and we will soon be able to leave the
> baremaps github organisation for a new home.
>
> In preparation for the changes ahead, I renamed the root package into
> org.apache.baremaps and updated the code style. These changes affect most
> source code and configuration files in the repository. I tried the snapshot
> release locally and everything works well.
>
> https://github.com/baremaps/baremaps/pull/496
>
> If you dream of a large cosmetic change in the codebase, now is the time
> to discuss it ;) We have a short window of time with few branches and pull
> requests open.
>
> Best regards,
>
> Bertil
>
>
> --
Sent from A Mobile Device