You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Sherry Chen (JIRA)" <ji...@apache.org> on 2011/07/06 23:19:16 UTC
[jira] [Created] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
back-port MAPREDUCE-2238 to 0.20-security
-----------------------------------------
Key: MAPREDUCE-2650
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Sherry Chen
Assignee: Sherry Chen
Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061697#comment-13061697 ]
Sherry Chen commented on MAPREDUCE-2650:
----------------------------------------
Todd,
I think you are referring IOException in Localizer.java.
It throws an exception when makedirs failed, not permission couldn't be set.
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070305#comment-13070305 ]
Mahadev konar commented on MAPREDUCE-2650:
------------------------------------------
Sherry,
I think Todd's comment was on localFS.setPermission() calls. Those calls would throw an exception in this patch and would just return false with a log warning in the original code. Is that correct?
Infact all the calls to setpermission have to been changed.
The mkdirs change is ok, but the other changes am not sure should be part of this patch?
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070308#comment-13070308 ]
Mahadev konar commented on MAPREDUCE-2650:
------------------------------------------
Actually just read through the comments in MAPREDUCE-2238. The patch looks good.
can you please post the results of ant test?
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Nathan Roberts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Roberts updated MAPREDUCE-2650:
--------------------------------------
Fix Version/s: 0.20.205.0
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067368#comment-13067368 ]
Sherry Chen commented on MAPREDUCE-2650:
----------------------------------------
Todd,
I did not make it clear in previous comment.
Throws an exception (when makedirs failed) semantics are used in trunk and CDH3.
It's good to put it in 0.20-security.
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sherry Chen updated MAPREDUCE-2650:
-----------------------------------
Affects Version/s: 0.20.205.0
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sherry Chen updated MAPREDUCE-2650:
-----------------------------------
Affects Version/s: 0.20.2
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2
> Reporter: Sherry Chen
> Assignee: Sherry Chen
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sherry Chen updated MAPREDUCE-2650:
-----------------------------------
Status: Patch Available (was: Open)
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061687#comment-13061687 ]
Todd Lipcon commented on MAPREDUCE-2650:
----------------------------------------
the changes in TaskLog seem to change semantics -- it used to just WARN if permissions couldn't be set, but now it throws an exception?
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated MAPREDUCE-2650:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just pushed this. Thanks Sherry!
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070685#comment-13070685 ]
Sherry Chen commented on MAPREDUCE-2650:
----------------------------------------
ant test passed.
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2, 0.20.205.0
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Sherry Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sherry Chen updated MAPREDUCE-2650:
-----------------------------------
Attachment: MAPREDUCE-2650.patch
Back-port MAPREDUCE:2238 to 0.20-security.
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2650) back-port MAPREDUCE-2238 to
0.20-security
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060869#comment-13060869 ]
Hadoop QA commented on MAPREDUCE-2650:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12485489/MAPREDUCE-2650.patch
against trunk revision 1143252.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/438//console
This message is automatically generated.
> back-port MAPREDUCE-2238 to 0.20-security
> -----------------------------------------
>
> Key: MAPREDUCE-2650
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2650
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.2
> Reporter: Sherry Chen
> Assignee: Sherry Chen
> Attachments: MAPREDUCE-2650.patch
>
>
> Dev had seen the attempt directory permission getting set to 000 or 111 in the CI builds and tests run on dev desktops with 0.20-security.
> MAPREDUCE-2238 reported and fixed the issue for 0.22.0, back-port to 0.20-security is needed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira