[GitHub] lucene-solr pull request:

[AlexanderYastrebov <gi...@git.apache.org>]

Github user AlexanderYastrebov commented on the pull request:

    https://github.com/apache/lucene-solr/commit/d403b14180c52526e760df1341219cc3102968bf#commitcomment-12932348
  
    In solr/core/src/java/org/apache/solr/handler/UpdateRequestHandler.java:
    In solr/core/src/java/org/apache/solr/handler/UpdateRequestHandler.java on line 143:
    pathVsLoaders is private, so you could not correctly override `createDefaultLoaders` now
    IMHO pathVsLoaders should be init outside `createDefaultLoaders` and map path to mime, not to loader


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org