You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by zEqueue <no...@github.com.INVALID> on 2020/10/09 08:54:36 UTC

[apache/incubator-teaclave] add pca function (#424)

## Description

add principal_components_analysis(pca) function.

Fixes # (issue)

## Type of change (select or add applied and delete the others)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates

## How has this been tested?

## Checklist

- [x] Fork the repo and create your branch from `master`.
- [x] If you&#39;ve added code that should be tested, add tests.
- [x] If you&#39;ve changed APIs, update the documentation.
- [x] Ensure the tests pass (see CI results).
- [x] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/424

-- Commit Summary --

  * add pca function

-- File Changes --

    M executor/Cargo.toml (2)
    M executor/src/builtin.rs (7)
    M function/src/lib.rs (3)
    A function/src/principal_components_analysis.rs (179)
    A tests/fixtures/functions/princopal_components_analysis/expected_result.txt (90)
    A tests/fixtures/functions/princopal_components_analysis/input.txt (90)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/424.patch
https://github.com/apache/incubator-teaclave/pull/424.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/424

Re: [apache/incubator-teaclave] add pca function (#424)

Posted by Mingshen Sun <no...@github.com.INVALID>.
There's some warning introduces by previous PR. I don't know why they're not linked. You can ignore them first. Like this:

```
error: unsafe function's docs miss `# Safety` section
  --> binder/src/binder.rs:80:5
   |
80 | /     pub unsafe fn destroy(&self) {
81 | |         let _ = sgx_destroy_enclave(self.enclave.geteid());
82 | |     }
   | |_____^
   |
   = note: `-D clippy::missing-safety-doc` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
```

I'll fix it later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/424#issuecomment-709758551

Re: [apache/incubator-teaclave] add pca function (#424)

Posted by Mingshen Sun <no...@github.com.INVALID>.
I have updated your PR to fix the above mentioned issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/424#issuecomment-710401311

Re: [apache/incubator-teaclave] add pca function (#424)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Can you run `make CLP=1` to check the code? I see some warnings. Please also fix it. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/424#issuecomment-709751350

Re: [apache/incubator-teaclave] add pca function (#424)

Posted by Mingshen Sun <no...@github.com.INVALID>.
Merged #424 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/424#event-3887780030