You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/09 06:20:17 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request, #18829: [fix][test][branch-2.10] Remove testGetTopic method
Technoboy- opened a new pull request, #18829:
URL: https://github.com/apache/pulsar/pull/18829
### Motivation
Remote test `testGetTopic`, because it was mis cherry-picked by #18181.
The original pr for this test is #17416
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #18829: [fix][test][branch-2.10] Remove testGetTopic method
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #18829:
URL: https://github.com/apache/pulsar/pull/18829#issuecomment-1432235486
@Technoboy- - this same test is causing `branch-2.11` to fail tests. I created #19523 thinking it was flaky, but it looks like it is similar to this one. Should we remove the test or do we need to fix the code? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #18829: [fix][test][branch-2.10] Remove testGetTopic method
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #18829:
URL: https://github.com/apache/pulsar/pull/18829#issuecomment-1447206648
After looking closer, I realized that cherry picking this #18181 was also incorrectly done to `branch-2.11`. The correct solution was to cherry pick this to `branch-2.11`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #18829: [fix][test][branch-2.10] Remove testGetTopic method
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18829:
URL: https://github.com/apache/pulsar/pull/18829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org