You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/28 09:41:45 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #7597: Switch to JRE base image from JDK
wu-sheng opened a new issue #7597:
URL: https://github.com/apache/skywalking/issues/7597
I think we should do this for dev images and official release. @hanahmily
@kezhenxu94 I think we should update agent's base image, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-907604823
Once we select `jre` image, we have to install OpenSSL to support `TLS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-908065325
@hanahmily `JDK->JRE` is not about CVE case, it is a just common way for a release image. Because we are not going to compile anything in the runtime, then JDK is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-908063801
Dev version is fine, because basically, we have image per commit id. It would be automatically fix in the name dev version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-908072222
> `JDK->JRE` is not about CVE case, it is a just common way for a release image. Because we are not going to compile anything in the runtime, then JDK is not required.
Why I mentioned the CVE case here intends to explain that even we select a specific `JRE`, it can't lock the underlying OS. A more common way to rebuild and re-push released images periodically. But Apache foundation projects can't follow this strategy easily unless they belong to official images, like tomcat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-908078367
Yes, I know. This is not a case we can't fix, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-908061196
> I know. But we should and lock the version to avoid unexpected change over time.
Do you mean we should opt for a tag with the minor version, for example, `jdk-11.0.12_7-alpine`? I agree with that.
But this strategy doesn't work regarding CVEs from underlying OS, a nightly build and push strategy can help us to fix it. Once the base image pushes a patch to fix some issues, we can fix it through rebuild and repush.
This strategy only works for dev images because release images should be pushed by hand. That means we have to update them manually and perioidyly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-908063493
Yes, changing binary codes(including OS level files) with time would be a very challenging work, I am afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7597:
URL: https://github.com/apache/skywalking/issues/7597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7597: Switch to JRE base image from JDK
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7597:
URL: https://github.com/apache/skywalking/issues/7597#issuecomment-907606477
I know. But we should and lock the version to avoid unexpected change over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org