You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/09/19 20:42:28 UTC
Review Request 62417: Installed newer cmake version in mesos-tidy
Docker image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62417/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
As of '85bc58196fc2bcb94e8e3193dacf5cc8a2af4301' the Mesos cmake setup
requires at least cmake-3.7.0. This patch install cmake-3.8.2 in the
mesos-tidy Docker image so we can build Mesos in that image as well.
Diffs
-----
support/mesos-tidy/Dockerfile 1cf582ece03335c8db92a242c5870f11249a4f26
Diff: https://reviews.apache.org/r/62417/diff/1/
Testing
-------
Built and ran the image with a modified `support/mesos-tidy.sh` that does not force-download the image.
Thanks,
Benjamin Bannier
Re: Review Request 62417: Installed newer cmake version in mesos-tidy
Docker image.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62417/
-----------------------------------------------------------
(Updated Oct. 8, 2017, 7:43 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Addressed mpark's comments.
Repository: mesos
Description
-------
As of '85bc58196fc2bcb94e8e3193dacf5cc8a2af4301' the Mesos cmake setup
requires at least cmake-3.7.0. This patch install cmake-3.8.2 in the
mesos-tidy Docker image so we can build Mesos in that image as well.
Diffs (updated)
-----
support/mesos-tidy/Dockerfile 1cf582ece03335c8db92a242c5870f11249a4f26
Diff: https://reviews.apache.org/r/62417/diff/2/
Changes: https://reviews.apache.org/r/62417/diff/1-2/
Testing
-------
Built and ran the image with a modified `support/mesos-tidy.sh` that does not force-download the image.
Thanks,
Benjamin Bannier
Re: Review Request 62417: Installed newer cmake version in mesos-tidy
Docker image.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62417/#review187275
-----------------------------------------------------------
Fix it, then Ship it!
support/mesos-tidy/Dockerfile
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/62417/#comment264194>
Do we want to skip this for now then?
support/mesos-tidy/Dockerfile
Lines 66-67 (patched)
<https://reviews.apache.org/r/62417/#comment264195>
Do we need either of these steps?
Can we just do this instead?
```
bash /tmp/install-cmake.sh --skip-license --prefix=/usr/local
```
- Michael Park
On Sept. 19, 2017, 1:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62417/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 1:42 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As of '85bc58196fc2bcb94e8e3193dacf5cc8a2af4301' the Mesos cmake setup
> requires at least cmake-3.7.0. This patch install cmake-3.8.2 in the
> mesos-tidy Docker image so we can build Mesos in that image as well.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 1cf582ece03335c8db92a242c5870f11249a4f26
>
>
> Diff: https://reviews.apache.org/r/62417/diff/1/
>
>
> Testing
> -------
>
> Built and ran the image with a modified `support/mesos-tidy.sh` that does not force-download the image.
>
>
> Thanks,
>
> Benjamin Bannier
>
>