[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #20706: fix(sql lab): MultiSelector component render twice

[GitBox <gi...@apache.org>]

Antonio-RiveroMartnez commented on code in PR #20706:
URL: https://github.com/apache/superset/pull/20706#discussion_r921113657


##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1213,16 +1213,20 @@ export function collapseTable(table) {
   };
 }
 
-export function removeTable(table) {
+export function removeTables(tables) {
   return function (dispatch) {
     const sync = isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE)
-      ? SupersetClient.delete({
-          endpoint: encodeURI(`/tableschemaview/${table.id}`),
-        })
+      ? Promise.all(
+          tables.map(table =>

Review Comment:
   Could `tables` be `null` or `undefined` at some point?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org